From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 100207 invoked by alias); 25 Feb 2016 14:26:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 100103 invoked by uid 89); 25 Feb 2016 14:26:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=sk:native-, sk:native, Map, agent X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 25 Feb 2016 14:26:04 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 7E33990E48; Thu, 25 Feb 2016 14:26:03 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u1PEQ1NI026121; Thu, 25 Feb 2016 09:26:02 -0500 Message-ID: <56CF0EF9.70807@redhat.com> Date: Thu, 25 Feb 2016 14:26:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Antoine Tremblay , gdb-patches@sourceware.org Subject: Re: [PATCH] Map registers to remote numbers when encoding an ax_reg or ax_reg_mask operation References: <1456406745-27854-1-git-send-email-antoine.tremblay@ericsson.com> In-Reply-To: <1456406745-27854-1-git-send-email-antoine.tremblay@ericsson.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-02/txt/msg00791.txt.bz2 On 02/25/2016 01:25 PM, Antoine Tremblay wrote: > When encoding the agent expression operation ax_reg or ax_reg_mask, the > register number used is internal to GDB. However GDBServer expects a tdesc > based number. > > This usually does not cause a problem since at the moment, for raw > registers GDBServer R trace action ignores the register mask and just > collects all registers. > > It can be a problem, however with pseudo registers on some platforms if the > tdesc number doesn't match the GDB internal register number. > > This is the case with ARM, the upcoming ARM tracepoint support, fails > these test cases without this patch: > > gdb.trace/collection.exp: collect register locals collectively:* > > GDBSever would exit with: unhandled register size > Since the register number is not mapped. > > This patch fixes these issues by calling gdbarch_remote_register_number > before encoding the register number in the ax_reg or ax_reg_mask operation. > > Tested on x86 native-gdbserver no regressions observed. > else > { > - int byte = reg / 8; > + int byte = 0; No need to zero initialize. > + > + /* Get the remote register number. */ > + reg = gdbarch_remote_register_number (ax->gdbarch, reg); > + byte = reg / 8; > > /* Grow the bit mask if necessary. */ > if (byte >= ax->reg_mask_len) > OK with ChangeLog entry. Thanks, Pedro Alves