From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 72354 invoked by alias); 25 Feb 2016 13:45:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 72254 invoked by uid 89); 25 Feb 2016 13:45:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=ftrace.exp, UD:ftrace.exp, ftraceexp, restarting X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 25 Feb 2016 13:45:38 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 1E5C4C057EC2; Thu, 25 Feb 2016 13:45:37 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u1PDjZV1004832; Thu, 25 Feb 2016 08:45:36 -0500 Message-ID: <56CF057F.1010208@redhat.com> Date: Thu, 25 Feb 2016 13:45:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: =?UTF-8?B?TWFyY2luIEtvxZtjaWVsbmlja2k=?= , gdb-patches@sourceware.org CC: antoine.tremblay@ericsson.com Subject: Re: [PATCH] gdb.trace: Move more target dependencies to trace-support.exp References: <1455884629-23354-1-git-send-email-koriakin@0x04.net> In-Reply-To: <1455884629-23354-1-git-send-email-koriakin@0x04.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2016-02/txt/msg00788.txt.bz2 On 02/19/2016 12:23 PM, Marcin Kościelnicki wrote: > For some strange reason, the call_insn setting code already knew about > arm, powerpc, s390, and mips - I went ahead and added the remaining > information about those. I'm not particularly sure if I got mips right, > but that won't matter anyway until someone actually writes tracepoint > support for that. The gdb.trace/entry-values.exp testcase runs some tests before restarting gdb for a trace session. That first part of the testcase runs on all targets. I'm not sure I really like this moving of test-specific variables that aren't shared by more tests, to the shared trace support file. Several of these are only used after gdb_target_supports_trace checks. So we could also say that the problem is that the tests are skipped. E.g., in ftrace.exp: # This expression is used for testing emit_reg. if [is_amd64_regs_target] { set arg0exp "\$rdi" } elseif [is_x86_like_target] { set arg0exp "*(int *) (\$ebp + 8)" } elseif { [istarget "aarch64*-*-*"] } { set arg0exp "\$x0" } else { set arg0exp "" } if { "$arg0exp" != "" } { test_ftrace_condition "($arg0exp > 500)" "globvar" { 6 7 8 9 10 } } If we removed the else branch or set arg0exp to "port me", someone porting fast tracepoints to a new architecture would notice it, instead of silently getting the test skipped. Thanks, Pedro Alves