From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 60471 invoked by alias); 25 Feb 2016 01:41:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 60445 invoked by uid 89); 25 Feb 2016 01:41:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1160 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 25 Feb 2016 01:41:11 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 65D33804F7; Thu, 25 Feb 2016 01:41:10 +0000 (UTC) Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u1P1f9h9009693 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 24 Feb 2016 20:41:10 -0500 Subject: Re: [PATCH v2 01/11] [PR gdb/14441] gdb: gdbtypes: add definitions for rvalue reference type To: Artemiy Volkov References: <1450661481-31178-1-git-send-email-artemiyv@acm.org> <1453229609-20159-1-git-send-email-artemiyv@acm.org> <1453229609-20159-2-git-send-email-artemiyv@acm.org> <56C763C2.8090207@redhat.com> <20160223070313.GA1564@gmail.com> <56CE574A.2000406@redhat.com> <20160225013125.GA13171@gmail.com> Cc: gdb-patches@sourceware.org From: Keith Seitz Message-ID: <56CE5BB5.3090900@redhat.com> Date: Thu, 25 Feb 2016 01:41:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <20160225013125.GA13171@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2016-02/txt/msg00769.txt.bz2 [bah -- forgot to "reply all"] On 02/24/2016 05:31 PM, Artemiy Volkov wrote: > On Wed, Feb 24, 2016 at 05:22:18PM -0800, Keith Seitz wrote: >> On 02/22/2016 11:03 PM, Artemiy Volkov wrote: >>> On Fri, Feb 19, 2016 at 10:49:38AM -0800, Keith Seitz wrote: >>> >>> Do you suggest keeping only the lvalue version of the reference type and >>> then adjust its type code from TYPE_CODE_REF to TYPE_CODE_RVALUE_REF on >>> lookup_rvalue_reference_type()? It seems somewhat hacky to me. E.g. how >>> would we be able to create a struct type for a complex type involving a >>> T&&, such as a typedef of it? >> >> Bah. No, I am wrong. Please disregard this comment. >> >> Sorry about the confusion. > > No problem at all. Correct me if I am wrong, but I think this > invalidates your remarks in 2/11 that refer to this change. Do those 2 > hunks in 2/11 look OK now? Yes, ignore my comments in make_reference_type. The only thing of note in there, then, is that we prefer the usage of explicit NULL checks: if (*reftype != NULL) ... instead of if (!*reftype) ... Keith