Re: [PATCH v5] Enable tracing of pseudo-registers on ARM

Yao Qi
2016-02-25T10:35:37Z

Antoine Tremblay <antoine.tremblay@ericsson.com> writes:

> +/* Implementation of the ax_pseudo_register_collect gdbarch function. */
> +
> +static int
> +arm_ax_pseudo_register_collect (struct gdbarch *gdbarch,
> + struct agent_expr *ax, int reg)
> +{
> + int rawnum = arm_pseudo_register_to_register (gdbarch, reg);
> +
> + /* Error. */
> + if (rawnum < 0)
> + return 1;
> +
> + /* Get the remote/tdesc register number. */
> + rawnum = gdbarch_remote_register_number (gdbarch, rawnum);
> +

I am expecting your patch v6 which moves gdbarch_remote_register_number
to the else branch of ax_reg/ax_reg_mask, if I correctly follow the discussion.

> + ax_reg_mask (ax, rawnum);
> +
> + return 0;
> +}

--
Yao (齐尧)