From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 87747 invoked by alias); 24 Feb 2016 11:22:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 87728 invoked by uid 89); 24 Feb 2016 11:22:04 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 24 Feb 2016 11:22:03 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 9C5CD8C545; Wed, 24 Feb 2016 11:22:02 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u1OBM1Hp028967; Wed, 24 Feb 2016 06:22:01 -0500 Message-ID: <56CD9259.9040007@redhat.com> Date: Wed, 24 Feb 2016 11:22:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Yao Qi , gdb-patches@sourceware.org Subject: Re: [PATCH 1/3] Generalize gdb.reverse/aarch64.exp References: <1456159999-5644-1-git-send-email-yao.qi@linaro.org> <1456159999-5644-2-git-send-email-yao.qi@linaro.org> In-Reply-To: <1456159999-5644-2-git-send-email-yao.qi@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-02/txt/msg00717.txt.bz2 On 02/22/2016 04:53 PM, Yao Qi wrote: > I said we can generialize gdb.reverse/aarch64.exp for other > architectures https://sourceware.org/ml/gdb-patches/2015-05/msg00482.html > and here is the patch to change aarch64.exp to insn-reverse.exp. > > gdb/testsuite: > > 2016-02-22 Yao Qi > > * gdb.reverse/aarch64.c: Rename it ... > * gdb.reverse/insn-reverse.c: to ... > [__aarch64__] Include arm_neon.h. > (testcase_ftype): New. > (testcases): New array. > (n_testcases): New. > (main): Call each element in testcases. > * gdb.reverse/aarch64.exp: Rename it ... > * gdb.reverse/insn-reverse.exp: to ... > Remove is_aarch64_target check. > (read_testcase): New. > Do the tests in a loop. > --- > gdb/testsuite/gdb.reverse/aarch64.c | 99 ---------------------- > gdb/testsuite/gdb.reverse/aarch64.exp | 115 ------------------------- > gdb/testsuite/gdb.reverse/insn-reverse.c | 121 +++++++++++++++++++++++++++ > gdb/testsuite/gdb.reverse/insn-reverse.exp | 130 +++++++++++++++++++++++++++++ Can you send a "git diff -M" so we can easily see the actual changes? (You can make that the default with git config.) Though I think even better would be to do the rename in one patch, and the generalization changes in a separate patch. Thanks, Pedro Alves