From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 98287 invoked by alias); 22 Feb 2016 22:41:38 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 98269 invoked by uid 89); 22 Feb 2016 22:41:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=sk:check_s, Hx-languages-length:945, (unknown), cell X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 22 Feb 2016 22:41:37 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 24074C00B8C0; Mon, 22 Feb 2016 22:41:35 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u1MMfXhv030204; Mon, 22 Feb 2016 17:41:35 -0500 Message-ID: <56CB8E9D.70605@redhat.com> Date: Mon, 22 Feb 2016 22:41:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Luis Machado , gdb-patches@sourceware.org CC: macro@linux-mips.org Subject: Re: [PATCH, v3] Expect SI_KERNEL or TRAP_BRKPT si_code values for MIPS breakpoint traps References: <1456179628-14249-1-git-send-email-lgustavo@codesourcery.com> In-Reply-To: <1456179628-14249-1-git-send-email-lgustavo@codesourcery.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-02/txt/msg00668.txt.bz2 On 02/22/2016 10:20 PM, Luis Machado wrote: > diff --git a/gdb/nat/linux-ptrace.h b/gdb/nat/linux-ptrace.h > index ba58717..72b32b1 100644 > --- a/gdb/nat/linux-ptrace.h > +++ b/gdb/nat/linux-ptrace.h > @@ -140,11 +140,16 @@ struct buffer; > in SPU code on a Cell/B.E. However, SI_KERNEL is never seen > on a SIGTRAP for any other reason. > > + The MIPS kernel uses the default si_code of SI_KERNEL for software > + breakpoints, hardware watchpoints and SIGTRAP's in general. If we get this for both software breakpoints and hardware watchpoints, then it seems to me that this change still leaves watchpoints broken, as I can't see how check_stopped_by_watchpoint is reached, in either gdb/linux-nat.c or gdbserver/linux-low.c. Also, "and SIGTRAP's in general." seems wrong. I hope that that's not the case for user-sent SIGTRAPs? Thanks, Pedro Alves