From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-129781-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 111903 invoked by alias); 22 Feb 2016 17:57:53 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 111887 invoked by uid 89); 22 Feb 2016 17:57:52 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=pushed, UD:unavailable.exp, unavailable.exp, unavailableexp
X-HELO: xyzzy.0x04.net
Received: from xyzzy.0x04.net (HELO xyzzy.0x04.net) (109.74.193.254) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 22 Feb 2016 17:57:50 +0000
Received: from hogfather.0x04.net (89-65-66-135.dynamic.chello.pl [89.65.66.135])	by xyzzy.0x04.net (Postfix) with ESMTPS id 43A393FE60;	Mon, 22 Feb 2016 18:58:42 +0100 (CET)
Received: from [192.168.13.108] (89-65-66-135.dynamic.chello.pl [89.65.66.135])	by hogfather.0x04.net (Postfix) with ESMTPSA id 6C50F58010B;	Mon, 22 Feb 2016 18:57:48 +0100 (CET)
Subject: Re: [PATCH] gdb.trace: Fix unavailable.exp if last register happens to be PC.
To: Yao Qi <qiyaoltc@gmail.com>
References: <1456126517-23020-1-git-send-email-koriakin@0x04.net> <86io1gd4tg.fsf@gmail.com>
Cc: gdb-patches@sourceware.org
From: =?UTF-8?Q?Marcin_Ko=c5=9bcielnicki?= <koriakin@0x04.net>
Message-ID: <56CB4C1C.1000606@0x04.net>
Date: Mon, 22 Feb 2016 17:57:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0
MIME-Version: 1.0
In-Reply-To: <86io1gd4tg.fsf@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
X-IsSubscribed: yes
X-SW-Source: 2016-02/txt/msg00665.txt.bz2

On 22/02/16 18:37, Yao Qi wrote:
> Marcin Kościelnicki <koriakin@0x04.net> writes:
>
>> unavailable.exp executes "info registers", expecting to find at least
>> two instances of "<unavailable>".  However, it uses
>> "<unavailable>.*<unavailable>" as the pattern, which doesn't match
>> when the last register happens to be available (eg. PC).  Change it
>> to ".*<unavailable>.*<unavailable>.*" instead.
>>
>> Noticed on s390, no regression on x86_64.
>>
>> gdb/testsuite/ChangeLog:
>>
>> 	* gdb.trace/unavailable.exp (gdb_unavailable_registers_test_1): Fix
>> 	info registers pattern.
>
> Patch looks good to me.
>

Thanks, pushed.