Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Luis Machado <lgustavo@codesourcery.com>, gdb-patches@sourceware.org
Cc: macro@linux-mips.org
Subject: Re: [PATCH, v2] Expect SI_KERNEL or TRAP_BRKPT si_code values for MIPS breakpoint traps
Date: Mon, 22 Feb 2016 13:16:00 -0000	[thread overview]
Message-ID: <56CB0A42.70507@redhat.com> (raw)
In-Reply-To: <1456145829-5052-1-git-send-email-lgustavo@codesourcery.com>

On 02/22/2016 12:57 PM, Luis Machado wrote:
> This is v2 of this patch. It was pre-approved by Maciej and i will commit
> it soon if there are no objections.

I'd like to have a short paragraph in linux-nat.h about MIPS's behavior,
below the ppc comment.  If you look at the x86 table above, which cases get
SI_KERNEL, and which don't?  Single-step is not applicable, since the
MIPS doesn't handle single-stepping itself (IIRC), but do we also get
SI_KERNEL hardware bps and watchpoints, for example?

> Further discussion with MIPS maintainers showed that, historically, MIPS
> kernels have never set a proper si_code and thus they use the default value of
> SI_KERNEL.
> 
> There are plans to update the MIPS kernel to provide more meaningful si_code
> values though, so we should expect both SI_KERNEL and TRAP_BRKPT from now
> on, as GDB will handle both correctly, like powerpc.

Thanks,
Pedro Alves


  reply	other threads:[~2016-02-22 13:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-22 12:57 Luis Machado
2016-02-22 13:16 ` Pedro Alves [this message]
2016-02-22 16:19   ` Maciej W. Rozycki
2016-02-24 11:57     ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56CB0A42.70507@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=lgustavo@codesourcery.com \
    --cc=macro@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox