From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7726 invoked by alias); 19 Feb 2016 18:54:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 7713 invoked by uid 89); 19 Feb 2016 18:54:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 19 Feb 2016 18:54:18 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 71BB296FB; Fri, 19 Feb 2016 18:54:17 +0000 (UTC) Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u1JIsGAR013307 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 19 Feb 2016 13:54:16 -0500 From: Keith Seitz Subject: Re: [PATCH v2 05/11] [PR gdb/14441] gdb: demangle: implement demangling for rvalue reference typenames To: Artemiy Volkov References: <1450661481-31178-1-git-send-email-artemiyv@acm.org> <1453229609-20159-1-git-send-email-artemiyv@acm.org> <1453229609-20159-6-git-send-email-artemiyv@acm.org> Cc: gdb-patches@sourceware.org Message-ID: <56C764D8.50103@redhat.com> Date: Fri, 19 Feb 2016 18:54:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <1453229609-20159-6-git-send-email-artemiyv@acm.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2016-02/txt/msg00615.txt.bz2 All nits here, too. On 01/19/2016 10:53 AM, Artemiy Volkov wrote: > 2016-01-19 Artemiy Volkov > > * gdb/cp-name-parser.y: Handle the '&&' token in typename. We normally put a production name in place of where one would normally use a function name. In this case, "(ptr_operator)". > @@ -827,7 +828,10 @@ typy_lookup_type (struct demangle_component *demangled, > switch (demangled_type) > { > case DEMANGLE_COMPONENT_REFERENCE: > - rtype = lookup_lvalue_reference_type (type); > + rtype = lookup_lvalue_reference_type (type); > + break; > + case DEMANGLE_COMPONENT_RVALUE_REFERENCE: > + rtype = lookup_rvalue_reference_type (type); > break; > case DEMANGLE_COMPONENT_POINTER: > rtype = lookup_pointer_type (type); Indentation? Keith