From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31029 invoked by alias); 19 Feb 2016 18:49:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 31012 invoked by uid 89); 19 Feb 2016 18:49:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=D*acm.org, harvard, Harvard, sk:allocat X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 19 Feb 2016 18:49:40 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id B0CBF6436E; Fri, 19 Feb 2016 18:49:39 +0000 (UTC) Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u1JInc8B030686 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 19 Feb 2016 13:49:39 -0500 From: Keith Seitz Subject: Re: [PATCH v2 01/11] [PR gdb/14441] gdb: gdbtypes: add definitions for rvalue reference type To: Artemiy Volkov References: <1450661481-31178-1-git-send-email-artemiyv@acm.org> <1453229609-20159-1-git-send-email-artemiyv@acm.org> <1453229609-20159-2-git-send-email-artemiyv@acm.org> Cc: gdb-patches@sourceware.org Message-ID: <56C763C2.8090207@redhat.com> Date: Fri, 19 Feb 2016 18:49:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <1453229609-20159-2-git-send-email-artemiyv@acm.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2016-02/txt/msg00611.txt.bz2 On 01/19/2016 10:53 AM, Artemiy Volkov wrote: > 2016-01-19 Artemiy Volkov > > * gdb/gdbtypes.h (enum type_code): Add TYPE_CODE_RVALUE_REF > constant. Nit: I believe the syntax for this would be: (enum type_code) : New constant. Also, remove the leading "gdb/" from all gdb/ChangeLog entries. [This appears in all patches.] > (TYPE_REFERENCE): New macro. > (struct type): Add rvalue_reference_type field. > (TYPE_RVALUE_REFERENCE_TYPE): New macro. > --- > gdb/gdbtypes.h | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/gdb/gdbtypes.h b/gdb/gdbtypes.h > index e775a1d..52419b4 100644 > --- a/gdb/gdbtypes.h > +++ b/gdb/gdbtypes.h > @@ -362,6 +364,12 @@ enum type_instance_flag_value > #define TYPE_ATOMIC(t) \ > (TYPE_INSTANCE_FLAGS (t) & TYPE_INSTANCE_FLAG_ATOMIC) > > +/* * C++ lvalue and rvalue references are equivalent in many contexts, > + thus create a convenience macro that checks if a type is either of them. */ > + > +#define TYPE_REFERENCE(t) \ > + (TYPE_CODE(t) == TYPE_CODE_REF || TYPE_CODE(t) == TYPE_CODE_RVALUE_REF) > + Nit: a single whitespace between TYPE_CODE and '(', TYPE_CODE (t) ... I think this macro could have a more helpful name. It's very close to TYPE_REFERENCE_TYPE. How about TYPE_IS_REFERENCE (similarly named to TYPE_IS_OPAQUE)? Then the comment becomes even clearer: "True if this type represents either an lvalue or rvalue reference type." > /* * Instruction-space delimited type. This is for Harvard architectures > which have separate instruction and data address spaces (and perhaps > others). > @@ -767,6 +775,10 @@ struct type > > struct type *reference_type; > > + /* * A C++ rvalue reference type added in C++0x. */ > + > + struct type *rvalue_reference_type; > + Why is this new field necessary? AFAICT, it is used exactly the same way as the reference_type field above it, and whether a reference type is an rvalue type is encoded into the type code. > /* * Variant chain. This points to a type that differs from this > one only in qualifiers and length. Currently, the possible > qualifiers are const, volatile, code-space, data-space, and > @@ -1229,6 +1241,7 @@ extern void allocate_gnat_aux_type (struct type *); > #define TYPE_TARGET_TYPE(thistype) TYPE_MAIN_TYPE(thistype)->target_type > #define TYPE_POINTER_TYPE(thistype) (thistype)->pointer_type > #define TYPE_REFERENCE_TYPE(thistype) (thistype)->reference_type > +#define TYPE_RVALUE_REFERENCE_TYPE(thistype) (thistype)->rvalue_reference_type > #define TYPE_CHAIN(thistype) (thistype)->chain > /* * Note that if thistype is a TYPEDEF type, you have to call check_typedef. > But check_typedef does set the TYPE_LENGTH of the TYPEDEF type, If struct type.rvalue_reference_type is superfluous, this is unneeded. Keith