From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 42470 invoked by alias); 19 Feb 2016 15:38:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 42444 invoked by uid 89); 19 Feb 2016 15:38:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 19 Feb 2016 15:38:31 +0000 Received: from svr-orw-fem-03.mgc.mentorg.com ([147.34.97.39]) by relay1.mentorg.com with esmtp id 1aWn8W-0000tN-Cq from Luis_Gustavo@mentor.com ; Fri, 19 Feb 2016 07:38:28 -0800 Received: from [172.30.0.169] (147.34.91.1) by svr-orw-fem-03.mgc.mentorg.com (147.34.97.39) with Microsoft SMTP Server id 14.3.224.2; Fri, 19 Feb 2016 07:38:27 -0800 Reply-To: Luis Machado Subject: Re: [PATCH v2] Fix logic in exec_file_locate_attach References: <20160219102447.GA29870@blade.nx> <1455880879-310-1-git-send-email-gbenson@redhat.com> To: Gary Benson , CC: Pedro Alves From: Luis Machado Message-ID: <56C736ED.9040505@codesourcery.com> Date: Fri, 19 Feb 2016 15:38:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1455880879-310-1-git-send-email-gbenson@redhat.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2016-02/txt/msg00605.txt.bz2 Gary, On 02/19/2016 09:21 AM, Gary Benson wrote: > Hi all, > > This is an updated version of the patch I posted yesterday. > It fails silently rather than throwing if the executable is > not in the sysroot, which both fixes the sysroot-escape issue > and results in a better GDB session for the user. > > Built and regtested on RHEL 6.6 x86_64. > > Luis, I think this patch will fix your connection drop without > any further changes. Could you test it please? Unfortunately it doesn't completely solve the problem i saw, as exec_file_find will still potentially throw errors and will disrupt the connection attempt or stop execution of a custom sequence of commands (as Pedro noted) when "attach" is part of the sequence. define foo attach >>>> execution stops here if an error is thrown info threads info registers end It still looks like a TRY/CATCH block is needed around at least exec_file_find.