From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 72394 invoked by alias); 18 Feb 2016 16:01:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 72329 invoked by uid 89); 18 Feb 2016 16:01:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=HContent-Transfer-Encoding:8bit X-HELO: xyzzy.0x04.net Received: from xyzzy.0x04.net (HELO xyzzy.0x04.net) (109.74.193.254) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 18 Feb 2016 16:00:59 +0000 Received: from hogfather.0x04.net (89-65-66-135.dynamic.chello.pl [89.65.66.135]) by xyzzy.0x04.net (Postfix) with ESMTPS id 49FCE3FE37; Thu, 18 Feb 2016 17:01:49 +0100 (CET) Received: from [192.168.1.62] (84-10-2-59.static.chello.pl [84.10.2.59]) by hogfather.0x04.net (Postfix) with ESMTPSA id CCBEB58008A; Thu, 18 Feb 2016 17:00:56 +0100 (CET) Subject: Re: [PATCH] gdb: Add guess_tracepoint_registers hook to gdbarch. To: Ulrich Weigand References: <20160218155844.0D7D96B9A@oc7340732750.ibm.com> Cc: lgustavo@codesourcery.com, arnez@linux.vnet.ibm.com, gdb-patches@sourceware.org From: =?UTF-8?Q?Marcin_Ko=c5=9bcielnicki?= Message-ID: <56C5EAB8.20400@0x04.net> Date: Thu, 18 Feb 2016 16:01:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160218155844.0D7D96B9A@oc7340732750.ibm.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2016-02/txt/msg00545.txt.bz2 On 18/02/16 16:58, Ulrich Weigand wrote: > Marcin Kościelnicki wrote: >> On 18/02/16 16:40, Ulrich Weigand wrote: >>> I don't think you actually need this include, do you? >>> >>> Otherwise, this patch is OK. >>> >>> Bye, >>> Ulrich >>> >> >> I do, the default_guess_tracepoint_registers function is declared there, >> and gdbarch.c uses it. > > Ah, right. You should probably move the prototype to arch-utils.h > (and then the implementation to arch-utils.c) to go with the other > default_ functions. Alright, I'll do that. > > Since gdbarch.h is included everywhere, we try to avoid having it > include other headers as far as possible. FWIW, the header include I added only ends up in gdbarch.c, .h is unaffected. > > Bye, > Ulrich >