[OB PATCH] Add missing cleanup in exec_file_locate_attach

Gary Benson
2016-02-17T17:02:22Z

Hi all,

exec_file_locate_attach allocates memory for full_exec_path (using
either exec_file_find, source_full_path_of or xstrdup) but this
memory is never freed. This commit adds the necessary cleanup.

Pushed as obvious.

Cheers,
Gary

--
gdb/ChangeLog:

* exec.c (exec_file_locate_attach): Add missing cleanup.
---
gdb/ChangeLog | 4 ++++
gdb/exec.c | 5 +++++
2 files changed, 9 insertions(+), 0 deletions(-)

diff --git a/gdb/exec.c b/gdb/exec.c
index 23c89c2..0b8c077 100644
--- a/gdb/exec.c
+++ b/gdb/exec.c
@@ -141,6 +141,7 @@ void
exec_file_locate_attach (int pid, int from_tty)
{
char *exec_file, *full_exec_path = NULL;
+ struct cleanup *old_chain;

/* Do nothing if we already have an executable filename. */
exec_file = (char *) get_exec_file (0);
@@ -170,8 +171,12 @@ exec_file_locate_attach (int pid, int from_tty)
full_exec_path = xstrdup (exec_file);
}

+ old_chain = make_cleanup (xfree, full_exec_path);
+
exec_file_attach (full_exec_path, from_tty);
symbol_file_add_main (full_exec_path, from_tty);
+
+ do_cleanups (old_chain);
}

/* Set FILENAME as the new exec file.
--
1.7.1