From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21816 invoked by alias); 17 Feb 2016 16:04:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 21802 invoked by uid 89); 17 Feb 2016 16:04:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=Format, HContent-Transfer-Encoding:8bit X-HELO: xyzzy.0x04.net Received: from xyzzy.0x04.net (HELO xyzzy.0x04.net) (109.74.193.254) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 17 Feb 2016 16:04:07 +0000 Received: from hogfather.0x04.net (89-65-66-135.dynamic.chello.pl [89.65.66.135]) by xyzzy.0x04.net (Postfix) with ESMTPS id 1A2743FE67; Wed, 17 Feb 2016 17:04:57 +0100 (CET) Received: from [192.168.1.62] (84-10-2-59.static.chello.pl [84.10.2.59]) by hogfather.0x04.net (Postfix) with ESMTPSA id D875858008C; Wed, 17 Feb 2016 17:04:04 +0100 (CET) Subject: Re: [PATCH 3/3] gdb/doc: Add documentation for tfile description section lines. To: Eli Zaretskii References: <56BB482A.1060307@redhat.com> <1455135588-21970-1-git-send-email-koriakin@0x04.net> <56BBB7A6.7000400@redhat.com> <56C4424D.9020400@0x04.net> <83ziuzuy31.fsf@gnu.org> Cc: palves@redhat.com, gdb-patches@sourceware.org From: =?UTF-8?Q?Marcin_Ko=c5=9bcielnicki?= Message-ID: <56C499F4.7040209@0x04.net> Date: Wed, 17 Feb 2016 16:04:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <83ziuzuy31.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2016-02/txt/msg00518.txt.bz2 On 17/02/16 16:59, Eli Zaretskii wrote: >> Cc: gdb-patches@sourceware.org >> From: Marcin Kościelnicki >> Date: Wed, 17 Feb 2016 10:50:05 +0100 >> >> On 10/02/16 23:20, Pedro Alves wrote: >>> On 02/10/2016 08:19 PM, Marcin Kościelnicki wrote: >>>> gdb/doc/ChangeLog: >>>> >>>> * gdb.texinfo (Trace File Format): Add documentation for description >>>> section lines. >>>> --- >>>> Here's the promised documentation for tdesc lines and then some. >>> >>> Excellent! Thanks much. >>> >>> Looks good to me content-wise, but let's get an ack from Eli as well. >>> >> >> Ping? > > Sorry, missed that. > > The patch is OK, but I wonder what about that FIXME there? > > Thanks. > Yeah, the FIXME is worded a bit weirdly and I wondered about it too, but the only thing it could've referred to was the description section line types (the trace frame section is already documented), so I figured it'd be best to remove it.