From: Simon Marchi <simon.marchi@ericsson.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: Joel Brobecker <brobecker@adacore.com>,
Pedro Alves <palves@redhat.com>, <gdb-patches@sourceware.org>
Subject: Re: [testsuite 7.11] Regression for i386-biarch-core.exp and others [Re: [PATCH] Always organize test artifacts in a directory hierarchy]
Date: Fri, 12 Feb 2016 18:34:00 -0000 [thread overview]
Message-ID: <56BE25A8.30609@ericsson.com> (raw)
In-Reply-To: <20160211212219.GA23888@host1.jankratochvil.net>
On 16-02-11 04:22 PM, Jan Kratochvil wrote:
> On Mon, 08 Feb 2016 20:26:41 +0100, Simon Marchi wrote:
>> Ok, I pushed this patch. I am now waiting to know what I broke.
>
> Running /home/jkratoch/redhat/gdb-clean/gdb/testsuite/gdb.arch/i386-biarch-core.exp ...
> PASS: gdb.arch/i386-biarch-core.exp: complete set gnutarget
> PASS: gdb.arch/i386-biarch-core.exp: core-file
> PASS: gdb.arch/i386-biarch-core.exp: .text is readable
> ->
> Running /home/jkratoch/redhat/gdb-clean/gdb/testsuite/gdb.arch/i386-biarch-core.exp ...
> PASS: gdb.arch/i386-biarch-core.exp: complete set gnutarget
> UNTESTED: gdb.arch/i386-biarch-core.exp: failed bzip2
>
> Reproducible with:
> tar xJf gdb-7.10.90.20160211.tar.xz;cd gdb-7.10.90.20160211;./configure;make;make -C gdb check//unix/-m64 RUNTESTFLAGS=gdb.arch/i386-biarch-core.exp
> Running /tmp/gdb-7.10.90.20160211/gdb/testsuite/gdb.arch/i386-biarch-core.exp ...
> sh: /tmp/gdb-7.10.90.20160211/gdb/testsuite.unix.-m64/gdb.arch/i386-biarch-core.core: No such file or directory
> === gdb Summary ===
> # of expected passes 1
> # of untested testcases 1
>
> I have not debugged it more yet.
>
>
> Jan
Hi Jan,
I think this patch should fix it. It simply makes the test use standard_output_file
for its output directory.
Simon
From c643fde26ecdc63c399ac4f26fd31920148fae77 Mon Sep 17 00:00:00 2001
From: Simon Marchi <simon.marchi@ericsson.com>
Date: Fri, 12 Feb 2016 13:17:32 -0500
Subject: [PATCH] i386-biarch-core.exp: Use standard_output_file
Fix the core file path to use the standard output directory.
gdb/testsuite/ChangeLog:
* i386-biarch-core.exp: Define corefile using
standard_output_file.
---
gdb/testsuite/gdb.arch/i386-biarch-core.exp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gdb/testsuite/gdb.arch/i386-biarch-core.exp b/gdb/testsuite/gdb.arch/i386-biarch-core.exp
index 607b947..4dc5ba6 100644
--- a/gdb/testsuite/gdb.arch/i386-biarch-core.exp
+++ b/gdb/testsuite/gdb.arch/i386-biarch-core.exp
@@ -40,7 +40,7 @@ gdb_test_multiple "complete set gnutarget " $test {
}
set corebz2file ${srcdir}/${subdir}/${testfile}.core.bz2
-set corefile ${objdir}/${subdir}/${testfile}.core
+set corefile [standard_output_file ${testfile}.core]
# Entry point of the original executable.
set address 0x400078
--
2.5.1
next prev parent reply other threads:[~2016-02-12 18:34 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-08 15:52 [PATCH] Always organize test artifacts in a directory hierarchy Simon Marchi
2016-01-12 13:00 ` Pedro Alves
[not found] ` <56952A6C.8070507@ericsson.com>
2016-01-13 11:11 ` Pedro Alves
2016-01-17 6:37 ` Joel Brobecker
2016-01-20 23:29 ` Simon Marchi
2016-01-25 21:24 ` Simon Marchi
2016-01-25 21:54 ` Simon Marchi
2016-02-01 22:41 ` Simon Marchi
2016-02-07 7:10 ` Joel Brobecker
2016-02-08 19:01 ` Simon Marchi
2016-02-08 19:26 ` Simon Marchi
2016-02-11 21:22 ` [testsuite 7.11] Regression for i386-biarch-core.exp and others [Re: [PATCH] Always organize test artifacts in a directory hierarchy] Jan Kratochvil
2016-02-12 18:34 ` Simon Marchi [this message]
2016-02-12 18:41 ` Pedro Alves
2016-02-12 18:56 ` Simon Marchi
2016-02-12 21:54 ` Simon Marchi
2016-02-12 23:01 ` Pedro Alves
2016-02-15 16:17 ` Simon Marchi
2016-02-12 18:47 ` Jan Kratochvil
2016-02-12 19:38 ` Simon Marchi
2016-02-15 17:58 ` [testsuite obv+7.11] Fix more testcases with standard_output_file [Re: [testsuite 7.11] Regression for i386-biarch-core.exp and others] Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56BE25A8.30609@ericsson.com \
--to=simon.marchi@ericsson.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox