From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 43038 invoked by alias); 12 Feb 2016 10:21:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 42900 invoked by uid 89); 12 Feb 2016 10:21:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=HContent-Transfer-Encoding:8bit X-HELO: xyzzy.0x04.net Received: from xyzzy.0x04.net (HELO xyzzy.0x04.net) (109.74.193.254) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 12 Feb 2016 10:21:50 +0000 Received: from hogfather.0x04.net (89-65-66-135.dynamic.chello.pl [89.65.66.135]) by xyzzy.0x04.net (Postfix) with ESMTPS id 93C143FE6A; Fri, 12 Feb 2016 11:22:38 +0100 (CET) Received: from [192.168.1.62] (84-10-2-59.static.chello.pl [84.10.2.59]) by hogfather.0x04.net (Postfix) with ESMTPSA id 1063F58008C; Fri, 12 Feb 2016 11:21:48 +0100 (CET) Subject: Re: [PATCH] gdb: Fix build failure in xml-tdesc.c without expat. To: Pedro Alves References: <56BDAEA4.1030500@redhat.com> <1455271799-20446-1-git-send-email-koriakin@0x04.net> <56BDB1B9.8070909@redhat.com> Cc: simon.marchi@ericsson.com, gdb-patches@sourceware.org, sergiodj@redhat.com From: =?UTF-8?Q?Marcin_Ko=c5=9bcielnicki?= Message-ID: <56BDB23B.3020806@0x04.net> Date: Fri, 12 Feb 2016 10:21:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <56BDB1B9.8070909@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2016-02/txt/msg00399.txt.bz2 On 12/02/16 11:19, Pedro Alves wrote: > On 02/12/2016 10:09 AM, Marcin Kościelnicki wrote: >> Introduced by 18d3cec54e1b4fce278dba436484846f8048d7d6. >> >> gdb/ChangeLog: >> >> * xml-tdesc.c (target_fetch_description_xml): Warn and return NULL >> when built without expat. >> --- >> How about that? > > There's a standard CL format for conditionally compiled code: > > * xml-tdesc.c (target_fetch_description_xml) [!HAVE_LIBEXPAT]: Warn > and return NULL. > > OK with that change. > > Thanks, > Pedro Alves > Thanks, pushed.