From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 39633 invoked by alias); 12 Feb 2016 10:19:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 39623 invoked by uid 89); 12 Feb 2016 10:19:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=HContent-Transfer-Encoding:8bit X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 12 Feb 2016 10:19:40 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id C42B4C0A9CDF; Fri, 12 Feb 2016 10:19:39 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u1CAJbZP027535; Fri, 12 Feb 2016 05:19:38 -0500 Message-ID: <56BDB1B9.8070909@redhat.com> Date: Fri, 12 Feb 2016 10:19:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: =?UTF-8?B?TWFyY2luIEtvxZtjaWVsbmlja2k=?= CC: simon.marchi@ericsson.com, gdb-patches@sourceware.org, sergiodj@redhat.com Subject: Re: [PATCH] gdb: Fix build failure in xml-tdesc.c without expat. References: <56BDAEA4.1030500@redhat.com> <1455271799-20446-1-git-send-email-koriakin@0x04.net> In-Reply-To: <1455271799-20446-1-git-send-email-koriakin@0x04.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2016-02/txt/msg00398.txt.bz2 On 02/12/2016 10:09 AM, Marcin Kościelnicki wrote: > Introduced by 18d3cec54e1b4fce278dba436484846f8048d7d6. > > gdb/ChangeLog: > > * xml-tdesc.c (target_fetch_description_xml): Warn and return NULL > when built without expat. > --- > How about that? There's a standard CL format for conditionally compiled code: * xml-tdesc.c (target_fetch_description_xml) [!HAVE_LIBEXPAT]: Warn and return NULL. OK with that change. Thanks, Pedro Alves