From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 129678 invoked by alias); 12 Feb 2016 10:06:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 129665 invoked by uid 89); 12 Feb 2016 10:06:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=H*f:sk:1455231, H*MI:sk:1455231, H*i:sk:1455231, HContent-Transfer-Encoding:8bit X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 12 Feb 2016 10:06:32 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 1E1F329AFA; Fri, 12 Feb 2016 10:06:30 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u1CA6SBu028337; Fri, 12 Feb 2016 05:06:29 -0500 Message-ID: <56BDAEA4.1030500@redhat.com> Date: Fri, 12 Feb 2016 10:06:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: =?UTF-8?B?TWFyY2luIEtvxZtjaWVsbmlja2k=?= , simon.marchi@ericsson.com CC: gdb-patches@sourceware.org, sergiodj@redhat.com Subject: Re: [PATCH] gdb: Fix build failure in xml-tdesc.c without expat. References: <56BCDABE.7080008@ericsson.com> <1455231367-29672-1-git-send-email-koriakin@0x04.net> In-Reply-To: <1455231367-29672-1-git-send-email-koriakin@0x04.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2016-02/txt/msg00396.txt.bz2 On 02/11/2016 10:56 PM, Marcin Kościelnicki wrote: > Introduced by 18d3cec54e1b4fce278dba436484846f8048d7d6. > > gdb/ChangeLog: > > * xml-tdesc.c (target_fetch_description_xml): Return NULL when > built without expat. > --- > OK to push? Or should we emit a warning in this case? Yes, I think we should emit a warning. Thanks, Pedro Alves