From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-129500-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 125892 invoked by alias); 11 Feb 2016 18:22:02 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 125877 invoked by uid 89); 11 Feb 2016 18:22:01 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 spammy=
X-HELO: usplmg21.ericsson.net
Received: from usplmg21.ericsson.net (HELO usplmg21.ericsson.net) (198.24.6.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 11 Feb 2016 18:22:01 +0000
Received: from EUSAAHC004.ericsson.se (Unknown_Domain [147.117.188.84])	by usplmg21.ericsson.net (Symantec Mail Security) with SMTP id 12.C3.32102.031DCB65; Thu, 11 Feb 2016 19:21:36 +0100 (CET)
Received: from [142.133.110.144] (147.117.188.8) by smtp-am.internal.ericsson.com (147.117.188.86) with Microsoft SMTP Server id 14.3.248.2; Thu, 11 Feb 2016 13:21:58 -0500
Subject: Re: [PATCH] arm-tdep.c: Change type of insn parameters
To: Yao Qi <qiyaoltc@gmail.com>
References: <1455146137-30672-1-git-send-email-simon.marchi@ericsson.com> <86wpqbpl7m.fsf@gmail.com>
CC: <gdb-patches@sourceware.org>
From: Simon Marchi <simon.marchi@ericsson.com>
Message-ID: <56BCD146.609@ericsson.com>
Date: Thu, 11 Feb 2016 18:22:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1
MIME-Version: 1.0
In-Reply-To: <86wpqbpl7m.fsf@gmail.com>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
X-SW-Source: 2016-02/txt/msg00384.txt.bz2

On 16-02-11 05:58 AM, Yao Qi wrote:
> Simon Marchi <simon.marchi@ericsson.com> writes:
> 
>>  /* Copy 16-bit Thumb(Thumb and 16-bit Thumb-2) instruction without any
>>     modification.  */
>>  static int
>> -thumb_copy_unmodified_16bit (struct gdbarch *gdbarch, unsigned int insn,
>> +thumb_copy_unmodified_16bit (struct gdbarch *gdbarch, uint32_t insn,
>>  			     const char *iname,
>>  			     struct displaced_step_closure *dsc)
> 
> The instruction here is 16-bit, so we should use "uint16_t".
> 
> OK with the change.
> 

Thanks, pushed with that changed.