From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 40278 invoked by alias); 11 Feb 2016 17:10:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 40265 invoked by uid 89); 11 Feb 2016 17:10:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=HContent-Transfer-Encoding:8bit X-HELO: mail-pa0-f65.google.com Received: from mail-pa0-f65.google.com (HELO mail-pa0-f65.google.com) (209.85.220.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 11 Feb 2016 17:10:09 +0000 Received: by mail-pa0-f65.google.com with SMTP id fl4so2664820pad.2 for ; Thu, 11 Feb 2016 09:10:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=F6ajvbSLPwnr2/oY3RUcNT55OZ4HJz72wccDh1w7Ygg=; b=MvWD5VKP7kyqPW/8pfuPtEWrV9RCs2hoYte5mgoURrAaXsFk3aE92HUbSVotYKQTbK 8fvxKx6ApOAQm7VVX1RkoGTM2e9VUBi8FPl5xgMjv7MqCr3ZQspYKpOrUblQSp6am/m4 4C708A1hvIO6FCiYmWZBU/zIlxaxlb51diRJ3jwRaf3ZnYwUBJlLx11FqHALjUTyqV9N whZvHbLq2EV1Ijx6+va8rxynMyupgEiorhWE1Ds0Y50HkFsSoveFs/VjYC+xLrN9WQ/m Kg8lPQhOQ99NA14GGBMr8Z8nTZxnXyexknExpk+YrGlaZz0W4j8dKVsvB7quCNG3hIPZ CkhQ== X-Gm-Message-State: AG10YOT8Ymed4WAm/v79OFTt0A2rwOWUA0bb9q1aNzIPTpmNq57dyjz1BVjgrkmiUYJQlA== X-Received: by 10.66.63.67 with SMTP id e3mr12962354pas.107.1455210607988; Thu, 11 Feb 2016 09:10:07 -0800 (PST) Received: from [127.0.0.1] (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id fa3sm13580371pab.45.2016.02.11.09.10.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 11 Feb 2016 09:10:07 -0800 (PST) Subject: Re: [PATCH 2/3] arm-tdep.c: Refactor arm_decode_dp_misc To: Simon Marchi References: <1455121027-27061-1-git-send-email-simon.marchi@ericsson.com> <1455121027-27061-3-git-send-email-simon.marchi@ericsson.com> <86h9hfpipt.fsf@gmail.com> Cc: gdb-patches@sourceware.org From: Yao Qi Message-ID: <56BCC06C.9000902@gmail.com> Date: Thu, 11 Feb 2016 17:10:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <86h9hfpipt.fsf@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2016-02/txt/msg00378.txt.bz2 On 11/02/16 11:52, Yao Qi wrote: > In short, I don't see how this patch improve the readability of the > code, and I feel hard mapping the code to the manual. s/ feel/ don't feel/ -- Yao (齐尧)