Re: [PATCH v3 3/3] btrace, frame: fix crash in get_frame_type

Pedro Alves
2016-02-11T16:26:31Z

On 02/11/2016 04:14 PM, Markus Metzger wrote:

> 2016-02-11 Markus Metzger <markus.t.metzger@intel.com>
>
> gdb/
> * frame.h (skip_tailcall_frames): Update comment.
> * frame.c (skip_artificial_frames, skip_tailcall_frames): Return NULL
> if only artificial frames are found. Update comment.
> (frame_unwind_caller_id): Handle NULL return.
> (frame_unwind_caller_pc, frame_unwind_caller_arch): Assert that
> skip_artificial_frames does not return NULL.
> (frame_pop): Add an error if only tailcall frames are found.
> * infcmd.c (finish_command): Move skip_tailcall_frames call into forward-
> execution case. Add an error if only tailcall frames are found.
>
> testsuite/
> * gdb.btrace/tailcall-only.exp: New.
> * gdb.btrace/tailcall-only.c: New.
> * gdb.btrace/x86_64-tailcall-only.S: New.
> * gdb.btrace/i686-tailcall-only.S: New.

OK.

Thanks,
Pedro Alves