From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 124433 invoked by alias); 10 Feb 2016 22:35:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 123880 invoked by uid 89); 10 Feb 2016 22:35:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1012, HContent-Transfer-Encoding:8bit X-HELO: xyzzy.0x04.net Received: from xyzzy.0x04.net (HELO xyzzy.0x04.net) (109.74.193.254) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 10 Feb 2016 22:35:34 +0000 Received: from hogfather.0x04.net (89-65-66-135.dynamic.chello.pl [89.65.66.135]) by xyzzy.0x04.net (Postfix) with ESMTPS id 094773FEBC; Wed, 10 Feb 2016 23:36:22 +0100 (CET) Received: from [192.168.13.108] (89-65-66-135.dynamic.chello.pl [89.65.66.135]) by hogfather.0x04.net (Postfix) with ESMTPSA id 2105D580092; Wed, 10 Feb 2016 23:35:32 +0100 (CET) Subject: Re: [PATCH 2/3] gdb.trace: Read XML target description from tfile. To: Pedro Alves References: <56BB34FE.8040108@redhat.com> <1455135549-21872-1-git-send-email-koriakin@0x04.net> <56BBB7A0.2000908@redhat.com> Cc: gdb-patches@sourceware.org From: =?UTF-8?Q?Marcin_Ko=c5=9bcielnicki?= Message-ID: <56BBBB34.6060106@0x04.net> Date: Wed, 10 Feb 2016 22:35:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <56BBB7A0.2000908@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2016-02/txt/msg00325.txt.bz2 On 10/02/16 23:20, Pedro Alves wrote: > On 02/10/2016 08:19 PM, Marcin Kościelnicki wrote: >> gdb/ChangeLog: >> >> * tracefile-tfile.c (trace_tdesc): New static variable. >> (tfile_open): Clear trace_tdesc, call target_find_description. >> (tfile_interp_line): Recognize tdesc lines. >> (tfile_close): Clear trace_tdesc. >> (tfile_xfer_partial_features): New function. >> (tfile_xfer_partial): Call tfile_xfer_partial_features. >> (tfile_append_tdesc_line): New function. >> --- >> Fixes applied, buffer used. > > Thanks. This is OK, with... > >> +/* Handles tdesc lines from tfile by appending the payload to >> + a global trace_tdesc variable. */ >> + >> +static void >> +tfile_append_tdesc_line (const char *line) >> +{ >> + int llen = strlen (line); >> + > > ... this unused var dropped. > >> + buffer_grow_str (&trace_tdesc, line); >> + buffer_grow_str (&trace_tdesc, "\n"); >> +} > > > Thanks, > Pedro Alves > Thanks, fixed and pushed.