From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 41009 invoked by alias); 10 Feb 2016 22:20:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 40939 invoked by uid 89); 10 Feb 2016 22:20:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=tfile, HContent-Transfer-Encoding:8bit X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 10 Feb 2016 22:20:18 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 4BB89804FD; Wed, 10 Feb 2016 22:20:17 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u1AMKGJd004878; Wed, 10 Feb 2016 17:20:16 -0500 Message-ID: <56BBB7A0.2000908@redhat.com> Date: Wed, 10 Feb 2016 22:20:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: =?UTF-8?B?TWFyY2luIEtvxZtjaWVsbmlja2k=?= CC: gdb-patches@sourceware.org Subject: Re: [PATCH 2/3] gdb.trace: Read XML target description from tfile. References: <56BB34FE.8040108@redhat.com> <1455135549-21872-1-git-send-email-koriakin@0x04.net> In-Reply-To: <1455135549-21872-1-git-send-email-koriakin@0x04.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2016-02/txt/msg00322.txt.bz2 On 02/10/2016 08:19 PM, Marcin Kościelnicki wrote: > gdb/ChangeLog: > > * tracefile-tfile.c (trace_tdesc): New static variable. > (tfile_open): Clear trace_tdesc, call target_find_description. > (tfile_interp_line): Recognize tdesc lines. > (tfile_close): Clear trace_tdesc. > (tfile_xfer_partial_features): New function. > (tfile_xfer_partial): Call tfile_xfer_partial_features. > (tfile_append_tdesc_line): New function. > --- > Fixes applied, buffer used. Thanks. This is OK, with... > +/* Handles tdesc lines from tfile by appending the payload to > + a global trace_tdesc variable. */ > + > +static void > +tfile_append_tdesc_line (const char *line) > +{ > + int llen = strlen (line); > + ... this unused var dropped. > + buffer_grow_str (&trace_tdesc, line); > + buffer_grow_str (&trace_tdesc, "\n"); > +} Thanks, Pedro Alves