From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 33077 invoked by alias); 10 Feb 2016 14:25:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 32984 invoked by uid 89); 10 Feb 2016 14:25:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1410, tfile, HContent-Transfer-Encoding:8bit X-HELO: xyzzy.0x04.net Received: from xyzzy.0x04.net (HELO xyzzy.0x04.net) (109.74.193.254) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 10 Feb 2016 14:25:28 +0000 Received: from hogfather.0x04.net (89-65-66-135.dynamic.chello.pl [89.65.66.135]) by xyzzy.0x04.net (Postfix) with ESMTPS id 25AF43FEBC; Wed, 10 Feb 2016 15:26:16 +0100 (CET) Received: from [192.168.1.62] (84-10-2-59.static.chello.pl [84.10.2.59]) by hogfather.0x04.net (Postfix) with ESMTPSA id 0BD6458008C; Wed, 10 Feb 2016 15:25:24 +0100 (CET) Subject: Re: [PATCH 0/4] Save target description in tfile. To: Pedro Alves , gdb-patches@sourceware.org References: <1454773157-31569-1-git-send-email-koriakin@0x04.net> <56BB482A.1060307@redhat.com> From: =?UTF-8?Q?Marcin_Ko=c5=9bcielnicki?= Message-ID: <56BB4853.8030608@0x04.net> Date: Wed, 10 Feb 2016 14:25:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <56BB482A.1060307@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2016-02/txt/msg00292.txt.bz2 On 10/02/16 15:24, Pedro Alves wrote: > On 02/06/2016 03:39 PM, Marcin Kościelnicki wrote: >> As discussed in the s390 trace thread, this adds target description >> in XML format to tfile format. The idea is simple: >> >> 1. target.xml is read from the target. >> 2. Includes are processed, resulting in a single in-memory XML file >> containing all the data. >> 3. The resulting file is stored in tfile header by prefixing every line >> with "tdesc ". We may insert a spurious newline at the end of file >> with this encoding, but that won't matter for XML. >> 4. When tfile is read, the XML is stored in an allocated buffer, and >> xfer for TARGET_OBJECT_AVAILABLE_FEATURES is implemented, reading >> from it. >> 5. target_find_description is called to force reading it. >> >> Patch #1 makes tsave write the XML data into tfile. Patch #2 makes >> tfile reader fetch and parse this data. Patch #3 fixes wrong register >> ordering in tfile_fetch_registers (noticed on x86_64 with AVX - >> plain x86_64 was apparently fine). Patch #4 fixes an off-by-one >> in the same function that prevented fetching the last register >> (orig_rax for plain x86_64, $ymm15h for x86_64 with AVX). >> > > I'd be good to also document the tdesc header lines in > the "Trace File Format" node in the manual. Alright, will do that in another commit. > > Thanks, > Pedro Alves >