From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31282 invoked by alias); 10 Feb 2016 14:24:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 31263 invoked by uid 89); 10 Feb 2016 14:24:45 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Includes, tfile, HContent-Transfer-Encoding:8bit X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 10 Feb 2016 14:24:45 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id DB4F5C00126C; Wed, 10 Feb 2016 14:24:43 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u1AEOgQt012177; Wed, 10 Feb 2016 09:24:43 -0500 Message-ID: <56BB482A.1060307@redhat.com> Date: Wed, 10 Feb 2016 14:24:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: =?UTF-8?B?TWFyY2luIEtvxZtjaWVsbmlja2k=?= , gdb-patches@sourceware.org Subject: Re: [PATCH 0/4] Save target description in tfile. References: <1454773157-31569-1-git-send-email-koriakin@0x04.net> In-Reply-To: <1454773157-31569-1-git-send-email-koriakin@0x04.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2016-02/txt/msg00291.txt.bz2 On 02/06/2016 03:39 PM, Marcin Kościelnicki wrote: > As discussed in the s390 trace thread, this adds target description > in XML format to tfile format. The idea is simple: > > 1. target.xml is read from the target. > 2. Includes are processed, resulting in a single in-memory XML file > containing all the data. > 3. The resulting file is stored in tfile header by prefixing every line > with "tdesc ". We may insert a spurious newline at the end of file > with this encoding, but that won't matter for XML. > 4. When tfile is read, the XML is stored in an allocated buffer, and > xfer for TARGET_OBJECT_AVAILABLE_FEATURES is implemented, reading > from it. > 5. target_find_description is called to force reading it. > > Patch #1 makes tsave write the XML data into tfile. Patch #2 makes > tfile reader fetch and parse this data. Patch #3 fixes wrong register > ordering in tfile_fetch_registers (noticed on x86_64 with AVX - > plain x86_64 was apparently fine). Patch #4 fixes an off-by-one > in the same function that prevented fetching the last register > (orig_rax for plain x86_64, $ymm15h for x86_64 with AVX). > I'd be good to also document the tdesc header lines in the "Trace File Format" node in the manual. Thanks, Pedro Alves