From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 471 invoked by alias); 10 Feb 2016 13:50:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 447 invoked by uid 89); 10 Feb 2016 13:50:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=HContent-Transfer-Encoding:8bit X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 10 Feb 2016 13:50:42 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id CEE0A552E6; Wed, 10 Feb 2016 13:50:41 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u1ADoeYp022702; Wed, 10 Feb 2016 08:50:41 -0500 Message-ID: <56BB4030.3040600@redhat.com> Date: Wed, 10 Feb 2016 13:50:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: =?UTF-8?B?TWFyY2luIEtvxZtjaWVsbmlja2k=?= , gdb-patches@sourceware.org Subject: Re: [PATCH 5/6] gdb/x86: Implement ax_pseudo_register_collect hook. References: <1454773157-31569-1-git-send-email-koriakin@0x04.net> <1454792070-25410-1-git-send-email-koriakin@0x04.net> <56BB3BAA.3050908@redhat.com> <56BB3C7E.4080102@0x04.net> In-Reply-To: <56BB3C7E.4080102@0x04.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2016-02/txt/msg00286.txt.bz2 On 02/10/2016 01:34 PM, Marcin Kościelnicki wrote: >> I don't understand this comment. amd64_ax_pseudo_register_collect >> checks i386_byte_regnum_p before ever reaching here, afaics. > > I've copied it from i386_pseudo_register_read_into_value - didn't make > that much sense to me either. Let's remove it from both places? Yes please. Thanks, Pedro Alves