From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 76735 invoked by alias); 10 Feb 2016 13:21:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 75673 invoked by uid 89); 10 Feb 2016 13:21:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1180, HContent-Transfer-Encoding:8bit X-HELO: xyzzy.0x04.net Received: from xyzzy.0x04.net (HELO xyzzy.0x04.net) (109.74.193.254) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 10 Feb 2016 13:21:57 +0000 Received: from hogfather.0x04.net (89-65-66-135.dynamic.chello.pl [89.65.66.135]) by xyzzy.0x04.net (Postfix) with ESMTPS id 660D73FEBC; Wed, 10 Feb 2016 14:22:45 +0100 (CET) Received: from [192.168.1.62] (84-10-2-59.static.chello.pl [84.10.2.59]) by hogfather.0x04.net (Postfix) with ESMTPSA id 7B39758008C; Wed, 10 Feb 2016 14:21:55 +0100 (CET) Subject: Re: [PATCH 3/4] gdb.trace: Use g packet order in tfile_fetch_registers. To: Pedro Alves , gdb-patches@sourceware.org References: <1454773157-31569-1-git-send-email-koriakin@0x04.net> <1454773157-31569-4-git-send-email-koriakin@0x04.net> <56BB3924.8050508@redhat.com> From: =?UTF-8?Q?Marcin_Ko=c5=9bcielnicki?= Message-ID: <56BB3973.5070305@0x04.net> Date: Wed, 10 Feb 2016 13:21:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <56BB3924.8050508@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2016-02/txt/msg00281.txt.bz2 On 10/02/16 14:20, Pedro Alves wrote: > On 02/06/2016 03:39 PM, Marcin Kościelnicki wrote: >> tfile_fetch_registers currently wrongly fetches registers using >> gdb order instead of g packet order. On x86_64 with AVX, this causes >> problems with ymm*h and orig_rax registers: gdb has ymm*h first, while >> g packet has orig_rax first. >> >> gdb/ChangeLog: >> >> * tracefile-tfile.c (tfile_fetch_registers): Use g packet order >> instead of gdb order. > > OK. > > The docs already explicitly say that we use g packet order, though the > bit about GDB register order seems odd: > > @table @code > @item R @var{bytes} > Register block. The number and ordering of bytes matches that of a > ^^^^^^^^ ^^^^^^^ > > @code{g} packet in the remote protocol. Note that these are the > ^^^^^^^^^^^^^^^ > actual bytes, in target order and @value{GDBN} register order, not a > ^^^^^^^^^^^^^^^^^^^^^^^^^^^ > > ???? > > hexadecimal encoding. > > > I can't make sense of that. I think we should > s/and @value{GDBN} register order,// . > > WDYT? > > Thanks, > Pedro Alves > Yeah, I think so. Should I add it to the patch?