From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 107082 invoked by alias); 10 Feb 2016 13:20:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 106061 invoked by uid 89); 10 Feb 2016 13:20:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=fetches, HContent-Transfer-Encoding:8bit X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 10 Feb 2016 13:20:39 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 2D58319245E; Wed, 10 Feb 2016 13:20:38 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u1ADKaTO009338; Wed, 10 Feb 2016 08:20:37 -0500 Message-ID: <56BB3924.8050508@redhat.com> Date: Wed, 10 Feb 2016 13:20:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: =?UTF-8?B?TWFyY2luIEtvxZtjaWVsbmlja2k=?= , gdb-patches@sourceware.org Subject: Re: [PATCH 3/4] gdb.trace: Use g packet order in tfile_fetch_registers. References: <1454773157-31569-1-git-send-email-koriakin@0x04.net> <1454773157-31569-4-git-send-email-koriakin@0x04.net> In-Reply-To: <1454773157-31569-4-git-send-email-koriakin@0x04.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2016-02/txt/msg00280.txt.bz2 On 02/06/2016 03:39 PM, Marcin Kościelnicki wrote: > tfile_fetch_registers currently wrongly fetches registers using > gdb order instead of g packet order. On x86_64 with AVX, this causes > problems with ymm*h and orig_rax registers: gdb has ymm*h first, while > g packet has orig_rax first. > > gdb/ChangeLog: > > * tracefile-tfile.c (tfile_fetch_registers): Use g packet order > instead of gdb order. OK. The docs already explicitly say that we use g packet order, though the bit about GDB register order seems odd: @table @code @item R @var{bytes} Register block. The number and ordering of bytes matches that of a ^^^^^^^^ ^^^^^^^ @code{g} packet in the remote protocol. Note that these are the ^^^^^^^^^^^^^^^ actual bytes, in target order and @value{GDBN} register order, not a ^^^^^^^^^^^^^^^^^^^^^^^^^^^ ???? hexadecimal encoding. I can't make sense of that. I think we should s/and @value{GDBN} register order,// . WDYT? Thanks, Pedro Alves