Re: [PATCH 1/3] gdb.trace: Save XML target description in tfile.

Marcin Kościelnicki
2016-02-11T22:31:27Z

On 11/02/16 20:02, Simon Marchi wrote:
> On 16-02-10 05:35 PM, Marcin KoÅ›cielnicki wrote:
>> On 10/02/16 23:20, Pedro Alves wrote:
>>> On 02/10/2016 08:18 PM, Marcin KoÅ›cielnicki wrote:
>>>> gdb/ChangeLog:
>>>>
>>>> * ctf.c (ctf_write_tdesc): New function.
>>>> (ctf_write_ops): Wire in ctf_write_tdesc.
>>>> * tracefile-tfile.c (tfile_write_tdesc): New function.
>>>> (tfile_write_ops): Wire in tfile_write_tdesc.
>>>> * tracefile.c (trace_save): Call write_tdesc method.
>>>> * tracefile.h (struct trace_file_write_ops): Add write_tdesc method.
>>>> * xml-tdesc.c (target_fetch_description_xml): New function.
>>>> * xml-tdesc.h: Add target_fetch_description_xml prototype.
>>>
>>> OK.
>>>
>>> Thanks,
>>> Pedro Alves
>>>
>>
>> Thanks, pushed.
>>
>
> Hi Marcin,
>
> Did you get an email from Builbot about this patch?
>
> An unrelated patch did fail because of this one:
> http://gdb-build.sergiodj.net/builders/Fedora-i686/builds/3021/steps/compile%20gdb/logs/stdio
>
> It happens when you build without expat. Maybe this particular slave doesn't have expat-devel
> installed, but others do. You can reproduce it locally by configuring with --with-expat=no or
> --without-expat.
>
> @Sergio: To ensure that we always test in the same conditions, perhaps we could add --with-expat,
> --with-python, and maybe others? Can it be done on a per-builder basis?
>
> This way, if the slave for a builder is mis-configured (doesn't have development packages for
> those), configure will fail right away. In an ideal world, to catch problems like the current
> one though, we should test gdb (at least see if it builds) with various combinations of
> with/without python, expat, etc.
>

I didn't get any email about the breakage before this one.

Thanks for noticing that. Sorry for the problem, I'll submit a patch soon.