From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 67023 invoked by alias); 9 Feb 2016 15:14:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 66907 invoked by uid 89); 9 Feb 2016 15:14:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.3 required=5.0 tests=BAYES_20,MIME_BASE64_BLANKS,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=Testing, vanilla, 1,3,8, UD:vla-ptype.exp X-HELO: mga02.intel.com Received: from mga02.intel.com (HELO mga02.intel.com) (134.134.136.20) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 09 Feb 2016 15:14:09 +0000 Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP; 09 Feb 2016 07:11:18 -0800 X-ExtLoop1: 1 Received: from wtedesch-mobl2.ger.corp.intel.com (HELO [172.28.205.68]) ([172.28.205.68]) by orsmga002.jf.intel.com with ESMTP; 09 Feb 2016 07:11:15 -0800 Subject: Re: [PATCH 1/2] fort_dyn_array: add basic fortran dyn array support To: Joel Brobecker References: <56B89C78.9050808@intel.com> <20160209113615.GE15342@adacore.com> Cc: qiyaoltc@gmail.com, "Heckel, Bernhard" , keven.boell@linux.intel.com, gdb-patches From: Walfred Tedeschi Message-ID: <56BA0193.3090408@intel.com> Date: Tue, 09 Feb 2016 15:14:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160209113615.GE15342@adacore.com> Content-Type: text/plain; charset="utf-8"; format="flowed" Content-Transfer-Encoding: base64 X-IsSubscribed: yes X-SW-Source: 2016-02/txt/msg00239.txt.bz2 QW0gMi85LzIwMTYgdW0gMTI6MzYgUE0gc2NocmllYiBKb2VsIEJyb2JlY2tl cjoKPj4gSSBkb24ndCB0aGluayBJIHdpbGwgYmUgYWJsZSB0byBmaXggdGhl IGZhaWx1cmVzIG9uIHRoZSBtZW50aW9uZWQKPj4gaG9zdHMvdGFyZ2V0cyBi ZWZvcmUgeW91Cj4+IGNyZWF0ZSB0aGUgYnJhbmNoLCBhcyBJIG5lZWQgdG8g cmVwbGljYXRlIHRoZSBlbnZpcm9ubWVudCBvbiBteSBlbmQgZmlyc3QgdG8K Pj4gc3RhcnQgaW52ZXN0aWdhdGluZy4KPj4gVGhlcmVmb3JlIEkgc3VnZ2Vz dCB0byByZXZlcnQgdGhlIGNoYW5nZSBmb3Igbm93LiBTb3JyeSBpZiB0aGlz IGNhdXNlZCBhbnkKPj4gaW5jb252ZW5pZW5jZS4KPgo+IFdlIG5lZWQgYSBn b29kIHJlYXNvbiBmb3IgcmV2ZXJ0aW5nIChFZzogcmVncmVzc2lvbnMgaW4g cHJlLWV4aXN0aW5nCj4gZmVhdHVyZXMpLiBGcm9tIHdoYXQgaSByZWFkIGJl bG93Ogo+Cj4+IEJlcm5oYXJkIGFuZCBJIHdlIGhhdmUgaW52ZXN0aWdhdGVk IHRoZSBpc3N1ZXMgcmVwb3J0ZWQuIElzc3VlcyB3ZXJlCj4+IHJlcHJvZHVj ZWQgYnkgdXNpbmcgdGhlIG5ld2VzdCBHQ0MuICBMb29rcyBsaWtlIHRoZSBp c3N1ZXMgYXJlIGluZGVwZW5kZW50Cj4+IGZyb20gdGhlIHRhcmdldCBhdCBm aXJzdCBzaWdodC4KPj4KPj4gSXNzdWVzIGNvdWxkIGJlIGRpdmlkZWQgaW50 byAzIGNhdGVnb3JpZXM6Cj4+Cj4+IDEuICBJc3N1ZSByb290IGNhdXNlcyB0 byBHQ0MgNS54IGFuZCBGb3J0cmFuICJhc3NvY2lhdGVkIiBpbnRyaW5zaWMu Cj4+IENvbXBpbGVyIGlzIG5vdCByZXBvcnRpbmcgdGhlIOKAnEFzc29jaWF0 ZWQgcHJvcGVydHkgY29ycmVjdGx5LiAoc2VlIHRlc3QgY2FzZQo+PiAxKQo+ PiBBZmZlY3RlZCB0ZXN0czoKPj4gZ2RiLmZvcnRyYW4vdmxhLXB0eXBlLmV4 cDogcHR5cGUgcHZsYSBub3QgaW5pdGlhbGl6ZWQKPj4gZ2RiLmZvcnRyYW4v dmxhLXZhbHVlLmV4cDogcHJpbnQgdW5kZWZpbmVkIHB2bGEKPj4gZ2RiLmZv cnRyYW4vdmxhLXZhbHVlLmV4cDogcHJpbnQgbm9uLWFzc29jaWF0ZWQgJnB2 bGEKPj4gZ2RiLmZvcnRyYW4vdmxhLXZhbHVlLmV4cDogcHJpbnQgdW5kZWZp bmVkIHB2bGEoMSwzLDgpCj4+IGdkYi5taS9taS12bGEtZm9ydHJhbi5leHA6 IGV2YWx1YXRlIG5vdCBhc3NvY2lhdGVkIHZsYQo+PiBnZGIubWkvbWktdmxh LWZvcnRyYW4uZXhwOiBjcmVhdGUgbG9jYWwgdmFyaWFibGUgcHZsYTJfbm90 X2Fzc29jaWF0ZWQKPj4gZ2RiLm1pL21pLXZsYS1mb3J0cmFuLmV4cDogaW5m byB0eXBlIHZhcmlhYmxlIHB2bGEyX25vdF9hc3NvY2lhdGVkCj4+Cj4+IDIu ICBUZXN0IGlzc3Vlcy4gVGVzdCB0YWtlIGludG8gYWNjb3VudCB0aGF0IGFy cmF5IGNyZWF0ZWQgaXMgaW5pdGlhbGl6ZWQgYnkKPj4gZGVmYXVsdC4gSW5p dGlhbGl6YXRpb24gZGVwZW5kcyBvbiB0aGUgY29tcGlsZXIgYWxzbyBGb3J0 cmFuIHN0YW5kYXJkIGRvZXMKPj4gbm90IHN0YXRlIHRoZSBuZWVkIGZvciBp bml0aWFsaXphdGlvbi4KPj4gQWZmZWN0ZWQgdGVzdHM6Cj4+IGdkYi5taS9t aS12bGEtZm9ydHJhbi5leHA6IGV2YWx1YXRlIGFsbG9jYXRlZCB2bGEKPj4K Pj4gMy4gIEdDQyBvciBHREIgZXJyb3IuIEJyZWFrcG9pbnQgaXMgY29tcGxl dGVseSBvZmYsIGJyZWFrcG9pbnQgb24gcmV0dXJuCj4+IGxpbmUgaXMgdHJp Z2dlcmVkIGJlZm9yZSB0aGUgZXhlY3V0aW9uIG9mIHRoZSBmdW5jdGlvbnMg Ym9keS4gRGVlcGVyCj4+IGludmVzdGlnYXRpb24gc2hvdWxkIGJlIGRvbmUg dG8gZGVmaW5lIHRoZSByZWFsIGlzc3VlLgo+PiBBZmZlY3RlZCB0ZXN0czoK Pj4gZ2RiLmNwL3ZsYS1jeHguZXhwCj4KPiBBcmUgdGhlc2UgcmVncmVzc2lv bnM/IE9yIGp1c3Qgc2hvd2luZyB0aGF0IHRoZSBuZXcgZmVhdHVyZSBhcmUK PiBub3Qgd29ya2luZyB3ZWxsIHdpdGggdGhlIG5ld2VyIEdDQz8KPgo+IEkg ZmVhciB0aGF0LCByZXZlcnRpbmcgY2VudHJhbCBjaGFuZ2VzIGF0IHRoaXMg c3RhZ2UgY291bGQKPiBkZXN0YWJpbGl6ZSB0aGUgYnJhbmNoLCBhbmQgdGhl cmVmb3JlIHdlIG5lZWQgdG8gYmUgdmVyeSBjYXJlZnVsCj4gYXMgdG8gd2hh dCB3ZSBkby4KPgoKSm9lbCwKCldoYXQgd2UgaGF2ZSBzZWVuIGlzIHRoYXQg dGhlIEdDQyA1LnggaXMgY2F1c2luZyB0aGUgaXNzdWUuCk9uIEZlZG9yYSAy MiB3ZSB1c2VkIGEgVmFuaWxsYSBHQ0MgdmVyc2lvbiA1LjMuMSB0ZXN0aW5n IG1haW5saW5lIEdEQiAKYW5kIEZlZG9yYSBHREIgKDcuOS4xLTIwLmZjMjIp IHdlIHJ1biBvbmx5IHRoZSBGb3J0cmFuIHRlc3RzdWl0ZS4KUmVzdWx0cyB3 ZXJlOgoKR0RCIG1haW5saW5lOiA0NjMgcGFzc2VzIGFuZCA2IGZhaWxzLgpH REIgRmVkb3JhOiA0NDkgcGFzc2VzIGFuZCAyMCBmYWlscy4KCkEgYml0IG1v cmUgYWJvdXQgdGhlIGNhdGVnb3JpZXM6CgoxLiBBc3NvY2lhdGUgaW50cmlu c2ljIGRvZXMgbm90IHdvcmsgZXZlbiBmcm9tIHRoZSBjb21waWxlciBpdHNl bGYuIEkuZS4gCldoZW4gb25lIGFkZHMgdGhlIGFzc29jaWF0ZWQgKHB2bGEp IGluIHRoZSBjb2RlIHdoZXJlIHRlc3Qgc3RvcHMgdG8gCmV2YWx1YXRlIGl0 IHJldHVybnMgdHJ1ZS4gTm8gY2hhbmNlIGZvciB0aGUgZGVidWdnZXIgaGVy ZS4KKHdlIHdpbGwgYWRkIGEgZGVmZWN0IGZvciBHRk9SVFJBTikKCjIuIFRl c3QgaXNzdWUgc3RpbGwgdGhlcmUuICBUZXN0aW5nIGZvciBpbml0aWFsaXpl ZCBhcnJheSB3aGVyZSBpdCBpcyAKbm90IG5lZWRlZC4KCjMuIEdEQiBGZWRv cmEgaGFzIHRoZSBzYW1lIGJlaGF2aW9yIHdoZW4gdGhlIGJyZWFrcG9pbnQg YXQgdGhlIGxhc3QgbGluZSAKaXMgaGl0LCBmdW5jdGlvbidzIGJvZHkgd2Fz IHN0aWxsIG5vdCBleGVjdXRlZC4gIEhvd2V2ZXIsIHRoaXMgaGFzIHRvIGJl IApmdXJ0aGVyIGludmVzdGlnYXRlZC4gSXMgcmVhbGx5IHRoZSBDb21waWxl ciB3aGljaCBpcyBnZW5lcmF0aW5nIGJhZCAKaW5mb3JtYXRpb24/CgpJbiB0 aGlzIHNlbnNlIHdlIGRvIG5vdCBzZWUgYW55IG9mIHRoZSBpc3N1ZXMgYXMg cmVncmVzc2lvbnMgZnJvbSB0aGUgCmRlYnVnZ2VyIHBvaW50IG9mIHZpZXcu CgpUaGFua3MgYW5kIHJlZ2FyZHMsCkZyZWQgJiBCZXJuaGFyZC4KCgoKCgoK CkludGVsIERldXRzY2hsYW5kIEdtYkgKUmVnaXN0ZXJlZCBBZGRyZXNzOiBB bSBDYW1wZW9uIDEwLTEyLCA4NTU3OSBOZXViaWJlcmcsIEdlcm1hbnkKVGVs OiArNDkgODkgOTkgODg1My0wLCB3d3cuaW50ZWwuZGUKTWFuYWdpbmcgRGly ZWN0b3JzOiBDaHJpc3RpbiBFaXNlbnNjaG1pZCwgQ2hyaXN0aWFuIExhbXBy ZWNodGVyCkNoYWlycGVyc29uIG9mIHRoZSBTdXBlcnZpc29yeSBCb2FyZDog Tmljb2xlIExhdQpSZWdpc3RlcmVkIE9mZmljZTogTXVuaWNoCkNvbW1lcmNp YWwgUmVnaXN0ZXI6IEFtdHNnZXJpY2h0IE11ZW5jaGVuIEhSQiAxODY5MjgK >From gdb-patches-return-129356-listarch-gdb-patches=sources.redhat.com@sourceware.org Tue Feb 09 15:21:11 2016 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 102730 invoked by alias); 9 Feb 2016 15:21:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 99998 invoked by uid 89); 9 Feb 2016 15:21:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:2096, commercial, Tel, office X-HELO: mga02.intel.com Received: from mga02.intel.com (HELO mga02.intel.com) (134.134.136.20) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 09 Feb 2016 15:21:05 +0000 Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga101.jf.intel.com with ESMTP; 09 Feb 2016 07:20:09 -0800 X-ExtLoop1: 1 Received: from irsmsx153.ger.corp.intel.com ([163.33.192.75]) by fmsmga004.fm.intel.com with ESMTP; 09 Feb 2016 07:20:07 -0800 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.210]) by IRSMSX153.ger.corp.intel.com ([169.254.9.69]) with mapi id 14.03.0248.002; Tue, 9 Feb 2016 15:20:05 +0000 From: "Metzger, Markus T" To: Pedro Alves , Joel Brobecker CC: "gdb-patches@sourceware.org" Subject: RE: [PATCH v2 2/3] frame: use get_prev_frame_always in skip_tailcall_frames Date: Tue, 09 Feb 2016 15:21:00 -0000 Message-ID: References: <1454681922-2228-1-git-send-email-markus.t.metzger@intel.com> <1454681922-2228-2-git-send-email-markus.t.metzger@intel.com> <20160207130057.GE20874@adacore.com> <56B9D08F.6060507@redhat.com> <20160209115819.GH15342@adacore.com> <56B9FA90.5030602@redhat.com> In-Reply-To: <56B9FA90.5030602@redhat.com> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-02/txt/msg00240.txt.bz2 Content-length: 2056 > -----Original Message----- > From: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] On Behalf Of Pedro Alves > Sent: Tuesday, February 9, 2016 3:41 PM > To: Metzger, Markus T ; Joel Brobecker > > Cc: gdb-patches@sourceware.org > Subject: Re: [PATCH v2 2/3] frame: use get_prev_frame_always in > skip_tailcall_frames >=20 > On 02/09/2016 02:25 PM, Metzger, Markus T wrote: >=20 > > I'm beginning to wonder if not all-but-the-backtrace-command-related > > get_prev_frame calls should really be calling get_prev_frame_always. > > > > The _always extension isn't very intuitive, though, given that this > > should be the standard function to use. Should get_prev_frame maybe > > be renamed to something like get_prev_frame_within_limit and > > get_prev_frame_always to get_prev_frame? >=20 > Maybe a good idea. See also: >=20 > https://sourceware.org/bugzilla/show_bug.cgi?id=3D15558 >=20 > I just noticed/remembered something -- the check for backtracing past main > and the entry point is in get_prev_frame, get_prev_frame_always bypasses > it. >=20 > This means that with your change, I think gdb now allows "finish" in "mai= n" or > in "_start". >=20 > Maybe not a bad change, but I though it'd call it out explicitly. There are 46 calls to get_prev_frame ignoring this patch. Each of them sho= uld maybe be modified to call get_prev_frame_always, instead. And none of this is currently covered by the test suite. The first step would probably be to look at all those calls and derive test= cases for each of them. Then fix the failing tests one by one. This is unrelated to this patch series. Let me therefore drop this patch. Regards, Markus. Intel Deutschland GmbH Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Christian Lamprechter Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928