From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8365 invoked by alias); 9 Feb 2016 14:41:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8343 invoked by uid 89); 9 Feb 2016 14:41:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:937, remembered X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 09 Feb 2016 14:41:22 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id B02A88F867; Tue, 9 Feb 2016 14:41:21 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u19EfK7V027580; Tue, 9 Feb 2016 09:41:20 -0500 Message-ID: <56B9FA90.5030602@redhat.com> Date: Tue, 09 Feb 2016 14:41:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: "Metzger, Markus T" , Joel Brobecker CC: "gdb-patches@sourceware.org" Subject: Re: [PATCH v2 2/3] frame: use get_prev_frame_always in skip_tailcall_frames References: <1454681922-2228-1-git-send-email-markus.t.metzger@intel.com> <1454681922-2228-2-git-send-email-markus.t.metzger@intel.com> <20160207130057.GE20874@adacore.com> <56B9D08F.6060507@redhat.com> <20160209115819.GH15342@adacore.com> In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-02/txt/msg00234.txt.bz2 On 02/09/2016 02:25 PM, Metzger, Markus T wrote: > I'm beginning to wonder if not all-but-the-backtrace-command-related > get_prev_frame calls should really be calling get_prev_frame_always. > > The _always extension isn't very intuitive, though, given that this should be > the standard function to use. Should get_prev_frame maybe be renamed to > something like get_prev_frame_within_limit and get_prev_frame_always > to get_prev_frame? Maybe a good idea. See also: https://sourceware.org/bugzilla/show_bug.cgi?id=15558 I just noticed/remembered something -- the check for backtracing past main and the entry point is in get_prev_frame, get_prev_frame_always bypasses it. This means that with your change, I think gdb now allows "finish" in "main" or in "_start". Maybe not a bad change, but I though it'd call it out explicitly. Thanks, Pedro Alves