Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: "Tedeschi, Walfred" <walfred.tedeschi@intel.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [obv. PATCH 1/1] Fix build breakage
Date: Tue, 09 Feb 2016 10:50:00 -0000	[thread overview]
Message-ID: <56B9C455.7040803@redhat.com> (raw)
In-Reply-To: <AC542571535E904D8E8ADAE745D60B194453709B@IRSMSX104.ger.corp.intel.com>

On 02/09/2016 10:37 AM, Tedeschi, Walfred wrote:
> From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-owner@sourceware.org] On Behalf Of Pedro Alves

> How is this better than what Simon proposed?

> I haven't seem Simon's proposal, have just feel sorry to have caused this breakage, and tried to fix.
> Just noticed that with the e-mail from Sergio this early morning.

Simon's fix was quoted in Sergio's e-mail.  :-)

> I will revert what I just pushed,

You reverted one patch unrelated patch too:

commit 0635c8759326e9431604b3359185cbf96740521d
Author:     Walfred Tedeschi <walfred.tedeschi@intel.com>

    Revert "Add a more helpful warning message to explain why some AArch64 relocations can overflow."

    This reverts commit 2ea53e003163338a403d5afbb2046cafb8f3abe9.

I've reapplied 2ea53e003163 now, preserving the original author (for "git blame").


BTW, given you first fixed the C++ build, and then broke it again with
the revert, you should have gotten another e-mail from the buildbot
about C++ build breakage.  Can you confirm whether you got one this time?

Thanks,
Pedro Alves


  reply	other threads:[~2016-02-09 10:50 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1455013458-14340-1-git-send-email-walfred.tedeschi@intel.com>
2016-02-09 10:31 ` Pedro Alves
2016-02-09 10:37   ` Tedeschi, Walfred
2016-02-09 10:50     ` Pedro Alves [this message]
2016-02-09 10:55       ` Pedro Alves
     [not found]       ` <AC542571535E904D8E8ADAE745D60B19445370CE@IRSMSX104.ger.corp.intel.com>
2016-02-09 11:05         ` Walfred Tedeschi
2016-02-09 11:13           ` Pedro Alves
2016-02-09 13:50             ` Walfred Tedeschi
2016-02-09 14:12               ` Pedro Alves
2016-02-09 15:36                 ` Walfred Tedeschi
2016-02-09 18:24                 ` Sergio Durigan Junior
2016-02-10 17:02                   ` Tedeschi, Walfred

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56B9C455.7040803@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=walfred.tedeschi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox