From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 85292 invoked by alias); 8 Feb 2016 19:28:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 85276 invoked by uid 89); 8 Feb 2016 19:28:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Keith, keith, court, charged X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 08 Feb 2016 19:28:04 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id D8D0F804F1; Mon, 8 Feb 2016 19:28:02 +0000 (UTC) Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u18JS1Sc028745 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 8 Feb 2016 14:28:02 -0500 Subject: Re: RFC: branching for GDB 7.11 soon? (possibly Wed) To: Joel Brobecker , "gdb-patches@sourceware.org ml" , Pedro Alves References: <20160201030638.GG4008@adacore.com> <20160207081230.GA20874@adacore.com> From: Keith Seitz X-Enigmail-Draft-Status: N1110 Message-ID: <56B8EC41.7080004@redhat.com> Date: Mon, 08 Feb 2016 19:28:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <20160207081230.GA20874@adacore.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2016-02/txt/msg00203.txt.bz2 On 02/07/2016 12:12 AM, Joel Brobecker wrote: > There is also a crash (regression): > > PR 19546 - gdb crash calling exec in the inferior > Initial guestimate from Pedro: > | Looks like a regression of the explicit locations work. > Still in Pedro's court, or could Keith help? I looked at this over the weekend and updated the bz. It seems pretty trivial, and the patch is very safe to use. In short, update_breakpoints_after_exec is charged with deleting any breakpoint with no location. momentary_breakpoint types were implemented to rely on this behavior. So b->location can be NULL, contrary to what I previously assumed. Simply handling NULL in location_empty_p fixes this. Writing a test for this now. Keith