From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 84818 invoked by alias); 8 Feb 2016 19:01:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 84787 invoked by uid 89); 8 Feb 2016 19:01:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=tcl, TCL, UD:fun_addr.exp, UD:gdb.ada X-HELO: usplmg20.ericsson.net Received: from usplmg20.ericsson.net (HELO usplmg20.ericsson.net) (198.24.6.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 08 Feb 2016 19:01:25 +0000 Received: from EUSAAHC008.ericsson.se (Unknown_Domain [147.117.188.96]) by usplmg20.ericsson.net (Symantec Mail Security) with SMTP id A1.2C.06940.B92E8B65; Mon, 8 Feb 2016 19:46:52 +0100 (CET) Received: from [142.133.110.144] (147.117.188.8) by smtp-am.internal.ericsson.com (147.117.188.98) with Microsoft SMTP Server id 14.3.248.2; Mon, 8 Feb 2016 14:01:23 -0500 Subject: Re: [PATCH] Always organize test artifacts in a directory hierarchy To: Joel Brobecker References: <1452268308-23845-1-git-send-email-simon.marchi@ericsson.com> <5694F8D2.5090807@redhat.com> <56952A6C.8070507@ericsson.com> <569630EC.2000702@redhat.com> <20160117063144.GB4059@adacore.com> <56A6926F.6040503@ericsson.com> <56AFDF1F.1040702@ericsson.com> <20160207070955.GC15342@adacore.com> CC: Pedro Alves , From: Simon Marchi Message-ID: <56B8E602.4050009@ericsson.com> Date: Mon, 08 Feb 2016 19:01:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160207070955.GC15342@adacore.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2016-02/txt/msg00201.txt.bz2 On 16-02-07 02:09 AM, Joel Brobecker wrote: >>> However, when building in-tree, srcdir is relative: ./gdb.ada/fun_addr. >>> When using parallel or always-in-outputs-directory mode, we are cd'ed in >>> the outputs directory. So -I$srcdir is relative to the current >>> directory, which is wrong. >>> >>> To fix it, I made the TCL variable srcdir (set in site.exp, from which >>> everything else is derived) always absolute. It is done by assigning >>> autoconf's abs_srcdir instead of autoconf's srcdir. This way -I$srcdir >>> will always be good, regardless of where we cd'ed to. A small apparent >>> change is that when running tests, DejaGnu will say: >>> >>> Running /tmp/binutils-gdb/gdb/testsuite/gdb.ada/fun_addr.exp ... >>> >>> instead of >>> >>> Running ./gdb.ada/fun_addr.exp ... >>> >>> I hope it's not too much of an annoyance. I think that it should make >>> the testsuite a tiny bit more robust against other bugs of the same >>> class. >>> >>> Regtested in & out of tree, only with native target. >>> --- >>> gdb/testsuite/Makefile.in | 3 ++- >>> 1 file changed, 2 insertions(+), 1 deletion(-) >>> >>> diff --git a/gdb/testsuite/Makefile.in b/gdb/testsuite/Makefile.in >>> index 7c251d3..38c3052 100644 >>> --- a/gdb/testsuite/Makefile.in >>> +++ b/gdb/testsuite/Makefile.in >>> @@ -21,6 +21,7 @@ srcdir = @srcdir@ >>> prefix = @prefix@ >>> exec_prefix = @exec_prefix@ >>> abs_builddir = @abs_builddir@ >>> +abs_srcdir = @abs_srcdir@ >>> >>> target_alias = @target_noncanonical@ >>> program_transform_name = @program_transform_name@ >>> @@ -119,7 +120,7 @@ $(abs_builddir)/site.exp site.exp: ./config.status Makefile >>> @echo "set target_alias $(target_alias)" >> ./tmp0 >>> @echo "set target_triplet ${target_canonical}" >> ./tmp0 >>> @echo "set build_triplet ${build_canonical}" >> ./tmp0 >>> - @echo "set srcdir ${srcdir}" >> ./tmp0 >>> + @echo "set srcdir ${abs_srcdir}" >> ./tmp0 >>> @echo "set tool gdb" >> ./tmp0 >>> @echo 'source $${srcdir}/lib/append_gdb_boards_dir.exp' >> ./tmp0 >>> @echo "## All variables above are generated by configure. Do Not Edit ##" >> ./tmp0 > > OK for me! Ok thanks, I pushed this one.