From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 102138 invoked by alias); 2 Feb 2016 14:22:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 102121 invoked by uid 89); 2 Feb 2016 14:22:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 02 Feb 2016 14:22:47 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 96D768F4FD; Tue, 2 Feb 2016 14:22:46 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u12EMiS5003597; Tue, 2 Feb 2016 09:22:45 -0500 Message-ID: <56B0BBB4.6050105@redhat.com> Date: Tue, 02 Feb 2016 14:22:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Luis Machado , "Maciej W. Rozycki" CC: gdb-patches@sourceware.org, jan.kratochvil@redhat.com Subject: Re: [PATCH] Handle loading improper core files gracefully in the mips backend. References: <1452277948-25292-1-git-send-email-lgustavo@codesourcery.com> <5693CE90.1060709@codesourcery.com> <5694F5BC.3050904@redhat.com> <5694FEB8.10406@codesourcery.com> <56950952.2030504@redhat.com> <56951F29.7070000@codesourcery.com> <56B0A809.6070101@codesourcery.com> <56B0BAEA.7@redhat.com> In-Reply-To: <56B0BAEA.7@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-02/txt/msg00057.txt.bz2 On 02/02/2016 02:19 PM, Pedro Alves wrote: > On 02/02/2016 12:58 PM, Luis Machado wrote: > Did you try to trigger the assertion by loading a 32-bit MIPS binary > into gdb, and playing with "set mips abi n64/o64...", "set mipsfpu", > etc? > > I think that adding a test to the testsuite that iterates through all > the possible combinations just to make sure gdb doesn't crash > would be great, and also show that the patch stands on its own > as well, irrespective of the bfd arch compatibility issues. TBC, I meant, the original patch that checked unsuitable ABI/ISA combinations. Thanks, Pedro Alves