From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 109902 invoked by alias); 1 Feb 2016 19:29:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 109888 invoked by uid 89); 1 Feb 2016 19:29:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=sk:forking X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 01 Feb 2016 19:29:56 +0000 Received: from svr-orw-fem-06.mgc.mentorg.com ([147.34.97.120]) by relay1.mentorg.com with esmtp id 1aQKAa-0001Qt-Kc from Don_Breazeal@mentor.com ; Mon, 01 Feb 2016 11:29:52 -0800 Received: from [172.30.9.175] (147.34.91.1) by svr-orw-fem-06.mgc.mentorg.com (147.34.97.120) with Microsoft SMTP Server (TLS) id 14.3.224.2; Mon, 1 Feb 2016 11:29:52 -0800 Subject: Re: [PATCH 3/3] PR remote/19496, timeout in forking-threads-plus-bkpt To: Pedro Alves , "gdb-patches@sourceware.org" References: <1453942111-1215-1-git-send-email-donb@codesourcery.com> <1453942111-1215-4-git-send-email-donb@codesourcery.com> <56AF4A0B.7030102@redhat.com> From: Don Breazeal Message-ID: <56AFB22A.6010006@codesourcery.com> Date: Mon, 01 Feb 2016 19:29:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <56AF4A0B.7030102@redhat.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2016-02/txt/msg00017.txt.bz2 On 2/1/2016 4:05 AM, Pedro Alves wrote: > On 01/28/2016 12:48 AM, Don Breazeal wrote: > >> >> --- >> gdb/infrun.c | 8 +++++++- >> 1 file changed, 7 insertions(+), 1 deletion(-) >> >> diff --git a/gdb/infrun.c b/gdb/infrun.c >> index 15210c9..e324864 100644 >> --- a/gdb/infrun.c >> +++ b/gdb/infrun.c >> @@ -5232,7 +5232,13 @@ Cannot fill $_exitsignal with the correct signal number.\n")); >> ecs->ptid = inferior_ptid; >> >> if (should_resume) >> - keep_going (ecs); >> + { >> + /* Make sure the thread is marked as running. If the event >> + occurred in the thread before we added it, it may have >> + never been marked running. */ >> + set_running (inferior_ptid, 1); >> + keep_going (ecs); >> + } >> else >> stop_waiting (ecs); >> return; >> > > Can you check whether this is still needed in current master? > > Specifically, whether a2077e254098 ([PATCH] Fix PR 19461: strange "info thread" > behavior in non-stop) already fixed this? > > See: > https://sourceware.org/ml/gdb-patches/2016-01/msg00446.html > https://sourceware.org/bugzilla/show_bug.cgi?id=19461 > > Thanks, > Pedro Alves > Hi Pedro, It looks like my patch is still needed. FYI, the values of the variables used to determine whether to call set_running in your patch are this, in my failing test case: follow_child 0 detach_fork 1 non_stop 1 sched_multi 0 target_is_non_stop_p () 1 Thanks, --Don