From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26229 invoked by alias); 28 Jan 2016 17:44:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 26216 invoked by uid 89); 28 Jan 2016 17:44:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=policy, HContent-Transfer-Encoding:8bit X-HELO: mail-pa0-f54.google.com Received: from mail-pa0-f54.google.com (HELO mail-pa0-f54.google.com) (209.85.220.54) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 28 Jan 2016 17:44:23 +0000 Received: by mail-pa0-f54.google.com with SMTP id ho8so26437187pac.2 for ; Thu, 28 Jan 2016 09:44:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=51BQAqpRitMpKh6GNrc5S3MHduKTWG3Pb/xBVujg33k=; b=TpproiXmCSm8dUsTQ/jysS/lSnyEPp1MdKEVZqjXGdMLUzdBll/OUg7Aq9KP7Twwm8 FfNFPcSZrRzkujEl0WDWchJsJlsOlGYDPerOweO/csGh8mceKmKOwlFVUzrn3mdcs4Mp dF/tIwe/0YRy3wfXZShTW0NUAUWSMNMS/6fcxCDV0x13Fh1QfLXgMPqh6kSejPEw1khs NVz0y10V4V8fK+VonZXUlWnqwKFofL2/BY7i6BaP0AB5TUraEz4VPBJXYhE+CvYjskQD R+JJM5Y9irWlWJ0eEZu/DIWHDsVROdiH0bsjzvacFZFpaB3qIL9yOhLfzGruWndc3o87 OcBQ== X-Gm-Message-State: AG10YOR1tSmgkoREESabmpo6JxsT2F6GFDBwnq+DTmODH19fhDeaf3kJ6dGu9/s9UYILnQ== X-Received: by 10.66.122.97 with SMTP id lr1mr6392314pab.68.1454003061780; Thu, 28 Jan 2016 09:44:21 -0800 (PST) Received: from [127.0.0.1] (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id d25sm15604576pfb.74.2016.01.28.09.44.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 28 Jan 2016 09:44:21 -0800 (PST) Subject: Re: [PATCH] Import strchrnul from gnulib and use it To: Simon Marchi References: <1453928650-30750-1-git-send-email-simon.marchi@ericsson.com> <86r3h1pud0.fsf@gmail.com> <56AA3EE5.5050705@ericsson.com> Cc: gdb-patches@sourceware.org From: Yao Qi Message-ID: <56AA5371.5080606@gmail.com> Date: Thu, 28 Jan 2016 17:44:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <56AA3EE5.5050705@ericsson.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2016-01/txt/msg00710.txt.bz2 On 28/01/16 16:16, Simon Marchi wrote: > Is there a reason for this? If one day we decide that we don't want strchrnul > anymore, we are probably going to forget about rawmemchr, and it will still be > imported even though it's not used. > > If it's a policy that has been discussed before, I have no problem adding it. > I would just like to understand. Yes, it was discussed before, https://sourceware.org/ml/gdb-patches/2014-10/msg00842.html and I think we'd better list all of them explicitly to know what do we import to GDB. -- Yao (齐尧)