From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 62081 invoked by alias); 28 Jan 2016 12:37:08 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 62046 invoked by uid 89); 28 Jan 2016 12:37:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 28 Jan 2016 12:37:06 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id C44897AE8C; Thu, 28 Jan 2016 12:37:04 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u0SCb3wu005544; Thu, 28 Jan 2016 07:37:03 -0500 Message-ID: <56AA0B6F.4070102@redhat.com> Date: Thu, 28 Jan 2016 12:37:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Walfred Tedeschi , eliz@gnu.org, brobecker@adacore.com CC: gdb-patches@sourceware.org Subject: Re: [PATCH V5 4/5] Adaptation of siginfo fixup for the new bnd fields References: <1453474456-13169-1-git-send-email-walfred.tedeschi@intel.com> <1453474456-13169-5-git-send-email-walfred.tedeschi@intel.com> In-Reply-To: <1453474456-13169-5-git-send-email-walfred.tedeschi@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-01/txt/msg00698.txt.bz2 On 01/22/2016 02:54 PM, Walfred Tedeschi wrote: > Caveat: No support for MPX on x32. What would it take to support that? > +/* These types below (native_*) define a siginfo type that is layout > + the most complete siginfo available for the architecture. */ nat_, not native_, afaics. I'd copy/edit this to: /* The nat_* types below define the most complete kernel siginfo type known for the architecture, independent of system/libc headers. */ > + > +typedef int nat_int_t; > +typedef void* nat_uptr_t; > + > +typedef int nat_time_t; > +typedef int nat_timer_t; > + > > @@ -192,54 +287,58 @@ typedef struct compat_x32_siginfo > static void > compat_siginfo_from_siginfo (compat_siginfo_t *to, siginfo_t *from) > { > + nat_siginfo_t from_nat; > + > + gdb_assert (sizeof (nat_siginfo_t) == sizeof (siginfo_t)); Make this a gdb_static_assert, and move it out of the function, below where nat_siginfo_t is defined. (Likewise the other instances in the other functions). OK with those changes. Thanks, Pedro Alves