From: Pedro Alves <palves@redhat.com>
To: Walfred Tedeschi <walfred.tedeschi@intel.com>,
eliz@gnu.org, brobecker@adacore.com
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH V5 3/5] Add bound related fields to the siginfo structure
Date: Thu, 28 Jan 2016 12:23:00 -0000 [thread overview]
Message-ID: <56AA083B.1060901@redhat.com> (raw)
In-Reply-To: <1453474456-13169-4-git-send-email-walfred.tedeschi@intel.com>
On 01/22/2016 02:54 PM, Walfred Tedeschi wrote:
> Both Linux and glibc have introduced bound related fields in the segmentation fault fields of the
> siginfo_t type. Ass the new fields to our x86's siginfo_t type too.
"Add the " ...
> @@ -342,6 +344,18 @@ linux_get_siginfo_type_with_fields (struct gdbarch *gdbarch,
> /* _sigfault */
> type = arch_composite_type (gdbarch, NULL, TYPE_CODE_STRUCT);
> append_composite_type_field (type, "si_addr", void_ptr_type);
> +
> + /* additional bound fields for _sigfault in case they are added. */
"Additional", uppercase.
"in case they were requested.".
> + if ((extra_fields & LINUX_SIGINFO_FIELD_ADDR_BND) != 0)
> + {
OK with those changes.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2016-01-28 12:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-22 15:36 [PATCH V5 0/5] Intel MPX bound violation support Walfred Tedeschi
2016-01-22 15:17 ` [PATCH V5 4/5] Adaptation of siginfo fixup for the new bnd fields Walfred Tedeschi
2016-01-28 12:37 ` Pedro Alves
2016-02-02 10:31 ` Pedro Alves
2016-02-02 13:58 ` Walfred Tedeschi
2016-01-22 15:17 ` [PATCH V5 1/5] Preparation for new siginfo on Linux Walfred Tedeschi
2016-01-28 12:20 ` Pedro Alves
2016-01-22 15:17 ` [PATCH V5 3/5] Add bound related fields to the siginfo structure Walfred Tedeschi
2016-01-28 12:23 ` Pedro Alves [this message]
2016-01-22 15:18 ` [PATCH V5 5/5] ntel MPX bound violation handling Walfred Tedeschi
2016-01-28 13:43 ` Pedro Alves
2016-01-28 13:49 ` Walfred Tedeschi
2016-01-28 14:18 ` Pedro Alves
2016-02-02 10:09 ` Walfred Tedeschi
2016-02-02 10:38 ` Pedro Alves
2016-02-02 10:41 ` Walfred Tedeschi
2016-01-22 15:18 ` [PATCH V5 2/5] Use linux_get_siginfo_type_with_fields for x86 Walfred Tedeschi
2016-01-28 12:19 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56AA083B.1060901@redhat.com \
--to=palves@redhat.com \
--cc=brobecker@adacore.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=walfred.tedeschi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox