From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 99861 invoked by alias); 28 Jan 2016 12:19:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 99851 invoked by uid 89); 28 Jan 2016 12:19:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=lowercase, 724, 246,7 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 28 Jan 2016 12:19:53 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id E661A742; Thu, 28 Jan 2016 12:19:51 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u0SCJoPU029109; Thu, 28 Jan 2016 07:19:50 -0500 Message-ID: <56AA0765.3030807@redhat.com> Date: Thu, 28 Jan 2016 12:19:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Walfred Tedeschi , eliz@gnu.org, brobecker@adacore.com CC: gdb-patches@sourceware.org Subject: Re: [PATCH V5 2/5] Use linux_get_siginfo_type_with_fields for x86 References: <1453474456-13169-1-git-send-email-walfred.tedeschi@intel.com> <1453474456-13169-3-git-send-email-walfred.tedeschi@intel.com> In-Reply-To: <1453474456-13169-3-git-send-email-walfred.tedeschi@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-01/txt/msg00695.txt.bz2 On 01/22/2016 02:54 PM, Walfred Tedeschi wrote: > Use linux_get_siginfo_type_with_fields for adding bound fields on > segmentation fault for i386/amd64 siginfo. > > 2016-01-15 Walfred Tedeschi > > gdb/ChangeLog: > > * linux-tdep.h (linux_get_siginfo_type_with_fields): Make extern. > * linux-tdep.c (linux_get_siginfo_type_with_fields): Make extern. > * i386-linux-tdep.h (x86_linux_get_siginfo_type): New > function. > * amd64-linux-tdep.c (amd64_linux_init_abi_common): Add > x86_linux_get_siginfo_type for the amd64 abi. > * i386-linux-tdep.c (x86_linux_get_siginfo_type): New > Function. "function", lowercase. > (i386_linux_init_abi): Add new function at the i386 ABI > initialization. > > --- a/gdb/i386-linux-tdep.h > +++ b/gdb/i386-linux-tdep.h > @@ -72,4 +72,7 @@ extern struct target_desc *tdesc_i386_avx512_linux; > > extern int i386_linux_gregset_reg_offset[]; > > +/* Returns x86 siginfo type with extra fields. */ /* Return the x86 Linux siginfo type. */ > +extern struct type *x86_linux_get_siginfo_type (struct gdbarch *gdbarch); > + > #endif /* i386-linux-tdep.h */ > diff --git a/gdb/linux-tdep.c b/gdb/linux-tdep.c > index 3757306..acc6e16 100644 > --- a/gdb/linux-tdep.c > +++ b/gdb/linux-tdep.c > @@ -246,7 +246,7 @@ get_linux_inferior_data (void) > /* This function is suitable for architectures that > extend/override the standard siginfo in a specific way. */ > > -static struct type * > +struct type * > linux_get_siginfo_type_with_fields (struct gdbarch *gdbarch, > linux_siginfo_extra_fields extra_fields) > { > diff --git a/gdb/linux-tdep.h b/gdb/linux-tdep.h > index b2680f8..ac342a3 100644 > --- a/gdb/linux-tdep.h > +++ b/gdb/linux-tdep.h > @@ -36,6 +36,10 @@ enum linux_siginfo_extra_field_values > DEF_ENUM_FLAGS_TYPE (enum linux_siginfo_extra_field_values, > linux_siginfo_extra_fields); > > +/* Return the siginfo type with additional fields. */ With this, we end up with two places documenting the function, one in the header, and another in the c file, which is a recipe for getting comments out of sync, which is exactly what happened. This one predates the revised one on the implementation side. Instead, please make this patch move the revised comment here, and replace the one there with "See linux-tdep.h." > +struct type *linux_get_siginfo_type_with_fields (struct gdbarch *gdbarch, > + linux_siginfo_extra_fields); > + OK with those changes. Thanks, Pedro Alves