From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7046 invoked by alias); 28 Jan 2016 12:06:38 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 7036 invoked by uid 89); 28 Jan 2016 12:06:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=sk:checkpo, UD:checkpoint-ns.exp X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 28 Jan 2016 12:06:36 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id C4D14C0B66FD; Thu, 28 Jan 2016 12:06:35 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u0SC6Y3e003314; Thu, 28 Jan 2016 07:06:34 -0500 Message-ID: <56AA044A.8040900@redhat.com> Date: Thu, 28 Jan 2016 12:06:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Don Breazeal , gdb-patches@sourceware.org Subject: Re: [PATCH v2] PR 18303, Tolerate malformed input for lookup_symbol-called functions. References: <1453944094-31885-1-git-send-email-donb@codesourcery.com> In-Reply-To: <1453944094-31885-1-git-send-email-donb@codesourcery.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-01/txt/msg00694.txt.bz2 On 01/28/2016 01:21 AM, Don Breazeal wrote: > The patch includes three new tests related to this. One is just > gdb.linespec/ls-errs.exp copied and converted to use C++ instead of C, and > to add a case using a file name containing a Windows-style logical drive > specifier. .... > gdb/testsuite/gdb.linespec/ls-errs-cp.cc | 36 +++++ > gdb/testsuite/gdb.linespec/ls-errs-cp.exp | 240 ++++++++++++++++++++++++++++ ... Can't we somehow reuse the existing test? Say, either: - move the main body of ls-errs.exp a procedure, and call it twice, once for each language, or, - make gdb.linespec/ls-errs-cp.exp set some $language var and then source gdb.linespec/ls-errs.exp, like gdb.base/checkpoint-ns.exp. Thanks, Pedro Alves