From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24550 invoked by alias); 26 Jan 2016 13:45:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 24540 invoked by uid 89); 26 Jan 2016 13:45:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=H*r:192.168.13, Bye, HContent-Transfer-Encoding:8bit X-HELO: xyzzy.0x04.net Received: from xyzzy.0x04.net (HELO xyzzy.0x04.net) (109.74.193.254) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 26 Jan 2016 13:45:50 +0000 Received: from hogfather.0x04.net (89-65-66-135.dynamic.chello.pl [89.65.66.135]) by xyzzy.0x04.net (Postfix) with ESMTPS id DF1373FE60; Tue, 26 Jan 2016 14:46:32 +0100 (CET) Received: from [192.168.13.108] (89-65-66-135.dynamic.chello.pl [89.65.66.135]) by hogfather.0x04.net (Postfix) with ESMTPSA id A822D580092; Tue, 26 Jan 2016 14:45:47 +0100 (CET) Subject: Re: [PATCH 1/8] gdb.trace: Fix write_inferior_data_ptr on 32-bit big-endian machines. To: Ulrich Weigand References: <20160126133215.0A5E125D3@oc7340732750.ibm.com> Cc: gdb-patches@sourceware.org, palves@redhat.com From: =?UTF-8?Q?Marcin_Ko=c5=9bcielnicki?= Message-ID: <56A7788B.6020900@0x04.net> Date: Tue, 26 Jan 2016 13:45:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160126133215.0A5E125D3@oc7340732750.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2016-01/txt/msg00652.txt.bz2 On 26/01/16 14:32, Ulrich Weigand wrote: > Marcin KoÃ…cielnicki wrote: > >> * tracepoint.c (write_inferior_data_ptr): Cast to uintptr_t, so that >> it works properly on big-endian machines where sizeof (CORE_ADDR) >> != sizeof (void *). > > This is the same problem that was detected on PowerPC here: > https://sourceware.org/ml/gdb-patches/2015-03/msg00996.html > > Unfortunately that patch, while approved, never got committed. It still > seems to be the better solution, since now there's two basically identical > routines write_inferior_data_ptr and write_inferior_data_pointer for no > particular reason ... > > Bye, > Ulrich > I'll remove the duplicated function. Is there a chance of getting this patchset commited? I see I duplicated a good chunk of work done there, it's a matter of time before someone likewise stumbles upon other already-fixed issues... Marcin Kościelnicki