From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 114725 invoked by alias); 25 Jan 2016 15:57:04 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 114650 invoked by uid 89); 25 Jan 2016 15:57:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1573, tfile, HContent-Transfer-Encoding:8bit X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 25 Jan 2016 15:57:01 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id E6109A9A; Mon, 25 Jan 2016 15:56:59 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u0PFuwFX009333; Mon, 25 Jan 2016 10:56:58 -0500 Message-ID: <56A645CA.1060405@redhat.com> Date: Mon, 25 Jan 2016 15:57:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: =?UTF-8?B?TWFyY2luIEtvxZtjaWVsbmlja2k=?= , gdb-patches@sourceware.org Subject: Re: [PATCH 0/8] gdb/s390: Add regular and fast tracepoint support. References: <1453637529-26972-1-git-send-email-koriakin@0x04.net> <56A6299E.4060706@redhat.com> <56A63114.3040105@0x04.net> In-Reply-To: <56A63114.3040105@0x04.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2016-01/txt/msg00625.txt.bz2 On 01/25/2016 02:28 PM, Marcin Kościelnicki wrote: > On 25/01/16 14:56, Pedro Alves wrote: >> On 01/24/2016 12:12 PM, Marcin Kościelnicki wrote: >> >>> 1. Target independent: tfile format doesn't contain target information >>> (tdesc). While this affects all platforms with multiple tdescs >>> (eg. x86_64 is unable to pull AVX registers from tfile for that >>> reason), it horribly breaks 31-bit s390 with high GPRs - it has >>> a completely different GPR layout from plain 31-bit s390, so the >>> collected registers will be garbled. I suppose the proper fix to >>> that would be to add tdesc information to tfile format. >> >> Yes, I think so too. >> >>> Unfortunately, I don't see a way to extend it in a backwards-compatible way. >> >> The trace file header is just a list of newline-terminated lines. >> We're free to add more header lines - older gdb's just warn about >> unknown lines. See tfile_interp_line. >> >> Thanks, >> Pedro Alves >> > > Very well. > > I was thinking of just stuffing the XML in the header. We can avoid > embedded newlines through hex-encoding it (or just stripping them, > shouldn't hurt XML...), and copy it straight from the target. That > would fail for targets that don't get tdesc from XML, but I'm not sure > we should worry about it. An alternative would be to invent some > serialization format for tdesc in tfile, but why do that when we already > have a perfectly good one... > > Should be quite simple, really. Does that sound OK? Yes. Thanks, Pedro Alves