Re: [PATCH] gdb: Add guess_tracepoint_registers hook to gdbarch.

Ulrich Weigand
2016-02-18T15:58:51Z

Marcin KoÃ…Â›cielnicki wrote:
> On 18/02/16 16:40, Ulrich Weigand wrote:
> > I don't think you actually need this include, do you?
> >
> > Otherwise, this patch is OK.
> >
> > Bye,
> > Ulrich
> >
>
> I do, the default_guess_tracepoint_registers function is declared there,
> and gdbarch.c uses it.

Ah, right. You should probably move the prototype to arch-utils.h
(and then the implementation to arch-utils.c) to go with the other
default_ functions.

Since gdbarch.h is included everywhere, we try to avoid having it
include other headers as far as possible.

Bye,
Ulrich

--
Dr. Ulrich Weigand
GNU/Linux compilers and toolchain
Ulrich.Weigand@de.ibm.com