Re: [PATCH] gdb: Add guess_tracepoint_registers hook to gdbarch.

Marcin Kościelnicki
2016-02-18T15:41:48Z

On 18/02/16 16:40, Ulrich Weigand wrote:
> Marcin KoÃ…Â›cielnicki wrote:
>
>> * gdbarch.c: Regenerate.
>> * gdbarch.h: Regenerate.
>> * gdbarch.sh: Add guess_tracepoint_registers hook, include
>> tracepoint.h.
>> * tracefile.c (tracefile_fetch_registers): Use the new gdbarch hook.
>> * tracepoint.c (default_guess_tracepoint_registers): New function.
>> * tracepoint.h (default_guess_tracepoint_registers): New prototype.
>
>> #include "observer.h"
>> #include "regcache.h"
>> #include "objfiles.h"
>> +#include "tracepoint.h"
>
> I don't think you actually need this include, do you?
>
> Otherwise, this patch is OK.
>
> Bye,
> Ulrich
>

I do, the default_guess_tracepoint_registers function is declared there,
and gdbarch.c uses it.