From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-128974-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 45269 invoked by alias); 23 Jan 2016 13:59:24 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 45187 invoked by uid 89); 23 Jan 2016 13:59:23 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=HContent-Transfer-Encoding:8bit
X-HELO: xyzzy.0x04.net
Received: from xyzzy.0x04.net (HELO xyzzy.0x04.net) (109.74.193.254) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 23 Jan 2016 13:59:20 +0000
Received: from hogfather.0x04.net (89-65-66-135.dynamic.chello.pl [89.65.66.135])	by xyzzy.0x04.net (Postfix) with ESMTPS id 8E9703FE65;	Sat, 23 Jan 2016 15:00:02 +0100 (CET)
Received: from [192.168.0.16] (87-206-68-155.dynamic.chello.pl [87.206.68.155])	by hogfather.0x04.net (Postfix) with ESMTPSA id 448C858008E;	Sat, 23 Jan 2016 14:59:18 +0100 (CET)
Subject: Re: [PATCH] gdb.trace: Fix unavailable-dwarf-piece.exp on big endian targets
To: Pedro Alves <pedro@palves.net>, gdb-patches@sourceware.org
References: <1453552454-18078-1-git-send-email-koriakin@0x04.net> <56A37E99.9080203@palves.net>
From: =?UTF-8?Q?Marcin_Ko=c5=9bcielnicki?= <koriakin@0x04.net>
Message-ID: <56A38735.1070503@0x04.net>
Date: Sat, 23 Jan 2016 13:59:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1
MIME-Version: 1.0
In-Reply-To: <56A37E99.9080203@palves.net>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
X-IsSubscribed: yes
X-SW-Source: 2016-01/txt/msg00595.txt.bz2

On 23/01/16 14:22, Pedro Alves wrote:
> On 01/23/2016 12:34 PM, Marcin Kościelnicki wrote:
>
>> diff --git a/gdb/testsuite/gdb.trace/unavailable-dwarf-piece.exp b/gdb/testsuite/gdb.trace/unavailable-dwarf-piece.exp
>> index 60820dd..e511915 100644
>> --- a/gdb/testsuite/gdb.trace/unavailable-dwarf-piece.exp
>> +++ b/gdb/testsuite/gdb.trace/unavailable-dwarf-piece.exp
>> @@ -325,10 +325,23 @@ with_test_prefix "tracing bar" {
>>       gdb_test "continue" "Continuing\\.\[ \r\n\]+Breakpoint.*"
>>       gdb_test_no_output "tstop"
>>
>> +    gdb_test_multiple "show endian" "show endian" {
>> +	-re ".* (big|little) endian.*$gdb_prompt $" {
>> +	    set endian $expect_out(1,string)
>> +	    pass "endianness: $endian"
>> +	}
>> +    }
>
> Do:
>
>      set endian ""
>      gdb_test_multiple "show endian" "show endian" {
>      ...
>
> Otherwise if that gdb_test_multiple fails, $endian doesn't exist,
> and the if below throws a tcl error.
>
> OK with that change.
>

Thanks, fixed and pushed.