From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 78831 invoked by alias); 22 Jan 2016 20:11:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 78797 invoked by uid 89); 22 Jan 2016 20:11:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1133, UD:gdb.gdb, gdb.gdb, gdbgdb X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 22 Jan 2016 20:11:20 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id A6F72C076619 for ; Fri, 22 Jan 2016 20:11:19 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u0MKBIhM025219; Fri, 22 Jan 2016 15:11:19 -0500 Message-ID: <56A28CE6.3090406@redhat.com> Date: Fri, 22 Jan 2016 20:11:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Jan Kratochvil CC: gdb-patches@sourceware.org Subject: Re: [testsuite patch]#2 Fix PR threads/19422 regression + Guile regression [Re: [PATCH+doc] Fix PR threads/19422 - show which thread caused stop] References: <1451950202-18024-1-git-send-email-palves@redhat.com> <5697ABE8.7060705@redhat.com> <20160122173020.GA5946@host1.jankratochvil.net> <20160122173100.GA5990@host1.jankratochvil.net> <56A276EB.1070208@redhat.com> <20160122200542.GA12621@host1.jankratochvil.net> In-Reply-To: <20160122200542.GA12621@host1.jankratochvil.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-01/txt/msg00584.txt.bz2 On 01/22/2016 08:05 PM, Jan Kratochvil wrote: > On Fri, 22 Jan 2016 19:37:31 +0100, Pedro Alves wrote: >> On 01/22/2016 05:31 PM, Jan Kratochvil wrote: >>> OK to check-in the fix for both of these problems? >> >> I think I'm confused -- the first hunk shows that it's >> thread 1 that receives the signal; then why do we need >> the "thread 1" command? > > I have looked more at it now and there is a race. The following outputs are > from unpatched FSF GDB HEAD: ... > > racy case #2: > > (xgdb) PASS: gdb.gdb/selftest.exp: Set xgdb_prompt > ^M > Thread 1 "xgdb" received signal SIGINT, Interrupt.^M > 0x00007ffff583bfdd in poll () from /lib64/libc.so.6^M > (gdb) FAIL: gdb.gdb/selftest.exp: send ^C to child process > signal SIGINT^M > Continuing with signal SIGINT.^M > ^C^M > Thread 2 "xgdb" received signal SIGINT, Interrupt.^M > [Switching to Thread 0x7ffff3b7f700 (LWP 13227)]^M So you need to adjust your patch in the bit that matched "Thread 1", right? Thanks, Pedro Alves