From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 95836 invoked by alias); 22 Jan 2016 08:38:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 95813 invoked by uid 89); 22 Jan 2016 08:38:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=Signal, H*r:10.253.24, H*r:sk:fmsmga1, H*RU:HELO X-HELO: mga11.intel.com Received: from mga11.intel.com (HELO mga11.intel.com) (192.55.52.93) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 22 Jan 2016 08:38:46 +0000 Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP; 22 Jan 2016 00:38:35 -0800 X-ExtLoop1: 1 Received: from wtedesch-mobl2.ger.corp.intel.com (HELO [172.28.205.68]) ([172.28.205.68]) by FMSMGA003.fm.intel.com with ESMTP; 22 Jan 2016 00:38:21 -0800 Message-ID: <56A1EA7C.9080809@intel.com> Date: Fri, 22 Jan 2016 08:38:00 -0000 From: Walfred Tedeschi User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Pedro Alves , Eli Zaretskii CC: brobecker@adacore.com, gdb-patches@sourceware.org Subject: Re: FW: [PATCH V4 6/6] Intel MPX bound violation handling. References: <1453387705-6597-1-git-send-email-walfred.tedeschi@intel.com> <1453387705-6597-7-git-send-email-walfred.tedeschi@intel.com> <83vb6m9a0u.fsf@gnu.org> <56A11694.4000502@intel.com> <83io2m95yt.fsf@gnu.org> <56A11E0E.80403@redhat.com> In-Reply-To: <56A11E0E.80403@redhat.com> Content-Type: text/plain; charset="windows-1252"; format="flowed" Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-01/txt/msg00555.txt.bz2 Am 1/21/2016 um 7:06 PM schrieb Pedro Alves: > On 01/21/2016 05:51 PM, Eli Zaretskii wrote: >>> Date: Thu, 21 Jan 2016 18:34:12 +0100 >>> From: Walfred Tedeschi > >>> Program received signal SIGSEGV, Segmentation fault upper bound >>> violation - bounds @{lbound =3D 0x603010, ubound =3D 0x603023@} accessi= ng >>> 0x60302f. >> >> I still think the word "address" should be added after "accessing". >> >> But if no one else thinks it's important, I don't insist. > > I'd think that accessing 0x60302f would be the most important > information here, and so it should be printed before the bounds even. > Say: > > Program received signal SIGSEGV, Segmentation fault > Upper bound violation while accessing address 0x60302f > Bounds: {lbound =3D 0x603010, ubound =3D 0x603023} > > Note we still repeat the string "bound" 4 times. Maybe we > could reduce that: > > Program received signal SIGSEGV, Segmentation fault > Upper bound violation while accessing address 0x60302f > Bounds: [lower =3D 0x603010, upper =3D 0x603023] > > But maybe lbound/ubound already have defined meaning to > the user. I will pick Pedro's suggestion, looks nicer to the user. Also adding the documentation lines to the Signal part. > > Thanks, > Pedro Alves > Thanks for the review and additions! -Fred Intel Deutschland GmbH Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Christian Lamprechter Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928