From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 43258 invoked by alias); 22 Jan 2016 07:22:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 43232 invoked by uid 89); 22 Jan 2016 07:22:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=inconvenience, H*r:sk:fmsmga1, H*RU:HELO, Hx-spam-relays-external:HELO X-HELO: mga11.intel.com Received: from mga11.intel.com (HELO mga11.intel.com) (192.55.52.93) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 22 Jan 2016 07:22:56 +0000 Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP; 21 Jan 2016 23:22:54 -0800 X-ExtLoop1: 1 Received: from kboell-mobl2.ger.corp.intel.com (HELO [172.28.205.135]) ([172.28.205.135]) by orsmga001.jf.intel.com with ESMTP; 21 Jan 2016 23:22:53 -0800 Subject: Re: [PATCH 1/2] fort_dyn_array: add basic fortran dyn array support To: Yao Qi References: <1435754532-17922-1-git-send-email-keven.boell@intel.com> <1435754532-17922-2-git-send-email-keven.boell@intel.com> <20150721180502.GN7406@adacore.com> <55C213C7.7070202@linux.intel.com> <20150805202301.GB14992@adacore.com> <51130.172.28.205.135.1438861308.squirrel@linux.intel.com> <20150820125159.GD4571@adacore.com> <5617A6FB.4050407@linux.intel.com> <86oacgsgdx.fsf@gmail.com> Cc: gdb-patches@sourceware.org, Joel Brobecker From: Keven Boell Message-ID: <56A1D8CD.3040905@linux.intel.com> Date: Fri, 22 Jan 2016 07:22:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <86oacgsgdx.fsf@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2016-01/txt/msg00554.txt.bz2 On 20.01.2016 11:18, Yao Qi wrote: > Keven Boell writes: > >> Fortran provide types whose values may be dynamically allocated >> or associated with a variable under explicit program control. >> The purpose of this commit is >> * to read allocated/associated DWARF tags and store them in >> the dynamic property list of main_type. >> * enable GDB to print the value of a dynamic array in Fortran >> in case the type is allocated or associated (pointer to >> dynamic array). >> >> Examples: >> (gdb) p vla_not_allocated >> $1 = >> >> (gdb) p vla_allocated >> $1 = (1, 2, 3) >> >> (gdb) p vla_ptr_not_associated >> $1 = >> >> (gdb) p vla_ptr_associated >> $1 = (1, 2, 3) >> >> Add basic test coverage for most dynamic array use-cases >> in Fortran. >> The commit contains the following tests: >> * Ensure that values of Fortran dynamic arrays >> can be evaluated correctly in various ways and states. >> * Ensure that Fortran primitives can be evaluated >> correctly when used as a dynamic array. >> * Dynamic arrays passed to subroutines and handled >> in different ways inside the routine. >> * Ensure that the ptype of dynamic arrays in >> Fortran can be printed in GDB correctly. >> * Ensure that dynamic arrays in different states >> (allocated/associated) can be evaluated. >> * Dynamic arrays passed to functions and returned from >> functions. >> * History values of dynamic arrays can be accessed and >> printed again with the correct values. >> * Dynamic array evaluations using MI protocol. >> * Sizeof output of dynamic arrays in various states. >> >> The patch was tested using the test suite on Ubuntu 12.04 64bit. > > Hi Keven, > The test cases added by this commit fail on some other OS and targets, > see this thread, https://sourceware.org/ml/gdb-testers/2015-q4/msg02136.html > can you take a look? > Hi Yao, Joel, I don't think I will be able to fix the failures on the mentioned hosts/targets before you create the branch, as I need to replicate the environment on my end first to start investigating. Therefore I suggest to revert the change for now. Sorry if this caused any inconvenience.