From: Pedro Alves <palves@redhat.com>
To: Eli Zaretskii <eliz@gnu.org>,
Walfred Tedeschi <walfred.tedeschi@intel.com>
Cc: palves@redhat.com, brobecker@adacore.com, gdb-patches@sourceware.org
Subject: Re: FW: [PATCH V4 6/6] Intel MPX bound violation handling.
Date: Thu, 21 Jan 2016 18:06:00 -0000 [thread overview]
Message-ID: <56A11E0E.80403@redhat.com> (raw)
In-Reply-To: <83io2m95yt.fsf@gnu.org>
On 01/21/2016 05:51 PM, Eli Zaretskii wrote:
>> Date: Thu, 21 Jan 2016 18:34:12 +0100
>> From: Walfred Tedeschi <walfred.tedeschi@intel.com>
>> Program received signal SIGSEGV, Segmentation fault upper bound
>> violation - bounds @{lbound = 0x603010, ubound = 0x603023@} accessing
>> 0x60302f.
>
> I still think the word "address" should be added after "accessing".
>
> But if no one else thinks it's important, I don't insist.
I'd think that accessing 0x60302f would be the most important
information here, and so it should be printed before the bounds even.
Say:
Program received signal SIGSEGV, Segmentation fault
Upper bound violation while accessing address 0x60302f
Bounds: {lbound = 0x603010, ubound = 0x603023}
Note we still repeat the string "bound" 4 times. Maybe we
could reduce that:
Program received signal SIGSEGV, Segmentation fault
Upper bound violation while accessing address 0x60302f
Bounds: [lower = 0x603010, upper = 0x603023]
But maybe lbound/ubound already have defined meaning to
the user.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2016-01-21 18:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-21 14:48 [PATCH V4 0/6] Intel MPX bound violation support Walfred Tedeschi
2016-01-21 14:48 ` [PATCH V4 3/6] Use linux_get_siginfo_type_with_fields for x86 Walfred Tedeschi
2016-01-21 14:49 ` [PATCH V4 4/6] Add bound related fields to the siginfo structure Walfred Tedeschi
2016-01-21 14:49 ` [PATCH V4 2/6] Prepararion for new siginfo on Linux Walfred Tedeschi
2016-01-21 15:05 ` Pedro Alves
2016-01-21 14:49 ` [PATCH V4 1/6] Merge gdb and gdbserver implementations for siginfo Walfred Tedeschi
2016-01-21 15:05 ` Pedro Alves
2016-01-21 14:49 ` [PATCH V4 6/6] Intel MPX bound violation handling Walfred Tedeschi
2016-01-21 16:23 ` Eli Zaretskii
[not found] ` <AC542571535E904D8E8ADAE745D60B194452CD61@IRSMSX104.ger.corp.intel.com>
2016-01-21 17:34 ` FW: " Walfred Tedeschi
2016-01-21 17:51 ` Eli Zaretskii
2016-01-21 18:06 ` Pedro Alves [this message]
2016-01-21 18:22 ` Eli Zaretskii
2016-01-22 8:38 ` Walfred Tedeschi
2016-01-21 14:49 ` [PATCH V4 5/6] Adaptation of siginfo fixup for the new bnd fields Walfred Tedeschi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A11E0E.80403@redhat.com \
--to=palves@redhat.com \
--cc=brobecker@adacore.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=walfred.tedeschi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox