From: Simon Marchi <simon.marchi@ericsson.com>
To: Pedro Alves <palves@redhat.com>, <gdb-patches@sourceware.org>
Subject: Re: [PATCH] gdb: Respect CXXFLAGS when building with C++ compiler
Date: Wed, 20 Jan 2016 22:53:00 -0000 [thread overview]
Message-ID: <56A00FC7.7030100@ericsson.com> (raw)
In-Reply-To: <569FF0B2.7070300@redhat.com>
On 16-01-20 03:40 PM, Pedro Alves wrote:
> Yeah, it crossed my mind too, but then all others end up _CFLAGS,
> like INTERNAL_CFLAGS, GLOBAL_CFLAGS, GDB_WERROR_CFLAGS,
> INTERNAL_WARN_CFLAGS, etc., which are used in c++ too,
> that I thought it ended up looking the odd one out. WDYT?
Then you can change the others too :)
INTERNAL_CFLAGS -> INTERNAL_COMPILER_FLAGS
GLOBAL_CFLAGS -> GLOBAL_COMPILER_FLAGS
GDB_WERROR_CFLAGS -> GDB_WERROR_COMPILER_FLAGS
etc...
But it's a minor detail and probably temporary too, so I'm fine
with COMPILER_CFLAGS.
next prev parent reply other threads:[~2016-01-20 22:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-20 11:07 Pedro Alves
2016-01-20 20:05 ` Simon Marchi
2016-01-20 20:40 ` Pedro Alves
2016-01-20 22:53 ` Simon Marchi [this message]
2016-01-21 11:37 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A00FC7.7030100@ericsson.com \
--to=simon.marchi@ericsson.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox